From 2be70ff42f01cd34ca23838df3eef4d7d16837d3 Mon Sep 17 00:00:00 2001 From: deefreak Date: Tue, 16 Jan 2024 10:21:56 +0530 Subject: [PATCH 1/2] doc changes --- INSTALLATION.md | 2 +- charts/ottoscalr/values.yaml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/INSTALLATION.md b/INSTALLATION.md index 250c4bd..ae48256 100644 --- a/INSTALLATION.md +++ b/INSTALLATION.md @@ -82,7 +82,7 @@ their default values. |-----------|------|---------|-------------| | `ottoscalr.config.metricsScraper.prometheusUrl` | string | `""` | URL where prometheus for the kubernetes cluster is running. Fetching metrics from a single or multiple prometheus instance(give comma separated urls) is supported. Metrics from multple prometheus instances will be aggregated. If you have 2 instances named `p8s1` and `p8s2`, it should be added like `"p8s1,p8s2"` | | `ottoscalr.config.metricsScraper.queryTimeoutSec` | int | `300` | Time in seconds within which the response for any query should be served by the prometheus | -| `ottoscalr.config.metricsScraper.querySplitIntervalHr` | int | `24` | The shortest period in hour for which data will be fetched from prometheus. If we are fetching data for 28 days, it will fetch data for this duration at a time and merge all of them. | +| `ottoscalr.config.metricsScraper.querySplitIntervalHr` | int | `8` | The shortest period in hour for which data will be fetched from prometheus. If we are fetching data for 28 days, it will be divided into `(28*24)/8` intervals and parallely data for all the intervals will be fetched and merged finally. This is required to execute the recommendation workflow faster. | | `ottoscalr.config.policyRecommendationController.maxConcurrentReconciles` | int | `1` | Maximum number of concurrent Reconciles of policy recommendation controller which can be run. | | `ottoscalr.config.policyRecommendationController.minRequiredReplicas` | int | `3` | The hpa.spec.minReplicas recommended by the controller will not have replicas minimum than this. | | `ottoscalr.config.policyRecommendationController.policyExpiryAge` | string | `3h` | Target Recommendation will be reached in multiple iterations and through different policies. This is the time after which a policy expires and next policy in the list can be applied. | diff --git a/charts/ottoscalr/values.yaml b/charts/ottoscalr/values.yaml index f074fd5..f15c6ef 100644 --- a/charts/ottoscalr/values.yaml +++ b/charts/ottoscalr/values.yaml @@ -87,8 +87,8 @@ ottoscalrConfigPath: "/etc/ottoscalr/config/ottoscalr_config.yaml" ottoscalr: config: metricsScraper: - prometheusUrl: - querySplitIntervalHr: 24 + prometheusUrl: "" + querySplitIntervalHr: 8 policyRecommendationController: maxConcurrentReconciles: 1 minRequiredReplicas: 3 @@ -102,7 +102,7 @@ ottoscalr: pollingIntervalMin: 180 policyRecommendationRegistrar: requeueDelayMs: 500 - excludedNamespaces: "apm-operator,argo-rollouts,cluster-registry,cryptex,default,event-exporter,event-synchronizer,fkadapter,flow-commons,gatekeeper-system,k8s-dashboard-oidc,keda,kube-node-lease,kube-public,kube-system,kubernetescamtl,kubernetescamtl-non-prod,metering-agent,monitoring,npd,paas-mtl,passivealerts,webhook,ottoscalr,istio-system,proxy-mesh-system,istio-monitoring,proxy-mesh-common,flow-argo-prod,flow-svc-prod,flow-env,varadhi,consus-snapshot,openebs-lvm,openebs-device,consus-lightbits,consus-fungible,consus-telemetry,gpu-operator,tenant-operator,vpa,hbaseoperator,aerospikeoperator,solroperator,zookeeperoperator,couchbaseoperator,kafkaoperator,mysqloperator,tp-k8s,kaas-app-metrics,bailiff,kaas-metrics-exporter-playground,event-synchronizer,fpg-insights-playground,cortex-xdr,fcp-rhs,qms-prod,eckoperator,gw-system,fcp-gateway,ads-disk-monitoring,apm-operator,scorpius-mgmt-prod,mtl-p8s,locust-ch-prod,locust-prod" + excludedNamespaces: "" cpuUtilizationBasedRecommender: metricWindowInDays: 28 stepSec: 30 From 415a783198b45f3de2fd19bc212f1d71184f2442 Mon Sep 17 00:00:00 2001 From: deefreak Date: Tue, 16 Jan 2024 10:39:52 +0530 Subject: [PATCH 2/2] doc changes --- INSTALLATION.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALLATION.md b/INSTALLATION.md index ae48256..131b75d 100644 --- a/INSTALLATION.md +++ b/INSTALLATION.md @@ -12,7 +12,7 @@ Ottoscalr can be installed in any kubernetes cluster which meets the prerequisit ## Building the image The following section outlines the docker image build process for the ottoscalr. -The following commands builds the image for the platform linux/amd64. Change the TARGETOS and TARGETARCH if it is required to be built for other platform. Run this from the root directory of the project. +The following commands builds the image for the platform linux/amd64. Change the TARGETOS and TARGETARCH if it is required to be built for other platform. Run this from the root directory of the project. Give your repository and tag for the image which will be built and pushed. ```console $ TARGETOS=linux;TARGETARCH=amd64;make docker-build docker-push IMG={repository}:{tag} ```