Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't resend messages when splitting up batches #24

Closed
dorner opened this issue Sep 10, 2019 · 0 comments · Fixed by #93
Closed

Don't resend messages when splitting up batches #24

dorner opened this issue Sep 10, 2019 · 0 comments · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@dorner
Copy link
Member

dorner commented Sep 10, 2019

DB Producer has a feature where, when the batch is too large and gets rejected by Kafka, it splits the batch up and tries again. This is fine when going from the full batch to smaller batches, but when splitting it up further, it may be resending messages unnecessarily:

  • Batch of 1000 gets split up into 10 batches of 100 of varying size
  • The first 5 batches get sent, but the 6th one is too large
  • DB Producer splits the original batch back up into 100 batches of 10 each, including the first 500 messages

These messages shouldn't be resent.

@dorner dorner added the bug Something isn't working label Sep 18, 2019
@DeeChau DeeChau self-assigned this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants