Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule evaluation caching #100

Closed
markphelps opened this issue Jun 22, 2019 · 6 comments · Fixed by #215
Closed

Rule evaluation caching #100

markphelps opened this issue Jun 22, 2019 · 6 comments · Fixed by #215
Assignees

Comments

@markphelps
Copy link
Collaborator

Describe the solution you'd like

Would like to support evaluation caching for rule based evaluation. IE https://flipt.dev/concepts/#evaluation

This would behave similarly to what was added in #6, but would likely be more complex since there are multiple entities that need to be cached (segments, distributions, rules, variants, etc) and invalidated.

One approach is to just cache the evaluation result and not the actual individual actors (noted above), but would have to come up with a scheme to invalidate this cached result if any of the above changed.

@stale
Copy link

stale bot commented Aug 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2019
@stale stale bot closed this as completed Aug 28, 2019
@badboyd
Copy link
Contributor

badboyd commented Jan 21, 2020

Can we open it again?

@badboyd
Copy link
Contributor

badboyd commented Jan 21, 2020

Can we just cache the rules and distributions, and do the evaluation? Then let the cache be purged after an expiration time.

@markphelps
Copy link
Collaborator Author

Yep! Ive actually started working on this this week

@markphelps markphelps reopened this Jan 21, 2020
@stale stale bot removed the stale label Jan 21, 2020
@markphelps markphelps removed the help wanted Halp label Jan 21, 2020
@markphelps
Copy link
Collaborator Author

Tracking in https://github.com/markphelps/flipt/tree/cache-redo, I hope to have this land early this coming week

@markphelps
Copy link
Collaborator Author

@badboyd this should be fixed as of v0.12

The docs on the caching feature are here: https://flipt.io/docs/configuration/#caching

Lemme know how it works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants