Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve database configuration #316

Closed
giddel opened this issue Jul 9, 2020 · 2 comments · Fixed by #326
Closed

improve database configuration #316

giddel opened this issue Jul 9, 2020 · 2 comments · Fixed by #326
Assignees
Labels
wip Work In Progress

Comments

@giddel
Copy link
Contributor

giddel commented Jul 9, 2020

I'm very happy for the Mysql support - thanks a lot!
As a little improvement I would suggest to split the configuration of the database credentials into separate keys in the config.yaml e.g.

    database:
        name:  flipt
        user: fliptuser
        password: very_secret
        host: localhost
        port: 3306
        protocol: mysql

And then build the connection string in the application itself based on these credentials.
So the user does not need to know the internals about the format of the connection string and the configuration is much more easier to understand.
We are using Flipt within a k8s cluster and manage the configuration of the credentials in an encrypted repository. At now I have once to encrypt the whole database connection string for the application and twice the credentials itself separately again for creating the database itself by the deployment job. This is not usual.

@markphelps
Copy link
Collaborator

I like it. Might keep url still as an alternative that will take precedence (and for backwards compatibility), but also allow for the configuration you described above.

@markphelps
Copy link
Collaborator

@giddel Added! Thanks for the feature request! Checkout the latest release and updated docs for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants