Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fails to render segments or flags #391

Closed
rio opened this issue Feb 23, 2021 · 4 comments · Fixed by #396
Closed

UI fails to render segments or flags #391

rio opened this issue Feb 23, 2021 · 4 comments · Fixed by #396
Labels

Comments

@rio
Copy link

rio commented Feb 23, 2021

The UI stays empty when requesting either segments or flags. The request tab does show entries being returned from the api. This happens on both Firefox 85.0.1 and Chrome 88.0.4324.182.

Version Info
Version: 1.2.0
Commit: 049e6ab
Build Date: 2021-02-23T09:09:50Z
Go Version: go1.15.5

To Reproduce
docker run -ti --rm -p 8080:8080 markphelps:v1.2.0

  1. Open your browser to localhost:8080
  2. Create a new flag
  3. Click the on flags button in the top
  4. Verify that the view stays empty
  5. Open the network tab
  6. Reload the page
  7. Click on the flags request and open the response tab
  8. Verify that the created flag is returned from the api

Expected behavior
The views should render the data returned from the api.

Screenshots
Screenshot from 2021-02-23 10-14-29

@rio rio added the bug label Feb 23, 2021
@markphelps
Copy link
Collaborator

@rio try 0.0.0.0:8080 there is a current issue with binding to localhost: #388 (comment)

@rio
Copy link
Author

rio commented Feb 24, 2021

Thanks, I'll keep an eye on it!

@markphelps
Copy link
Collaborator

Update: I have a fix for this in #396. Once the tests run/pass I'll release v1.2.1

@rio
Copy link
Author

rio commented Mar 10, 2021

Great! Can confirm this works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants