Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when opening an external link #152

Closed
john-light opened this issue Apr 2, 2019 · 1 comment
Closed

Warn users when opening an external link #152

john-light opened this issue Apr 2, 2019 · 1 comment
Milestone

Comments

@john-light
Copy link
Contributor

On the recent transactions section, for example, there is a "view details" button that will automatically open a link to an Etherscan web page. There is no indication that this opens a web page to a third party service.

Proposed solution
Show a pop-up window that says something like:

"This will open a link to an external web page: https://etherscan.com/....... Continue / Cancel"

With the option to copy the link by clicking a little "copy" icon next to it (in case the user prefers to open the link in a non-default browser, or cut out the txid but discard the rest of the link).

@floating floating added this to the v0.2.0 milestone Aug 2, 2019
@floating
Copy link
Owner

This functionality is in 0.2 and will be officially released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants