remove linux altGr detection, replace windows altGr with Control + Alt #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosewobbler
changed the title
mholtzman
previously approved these changes
May 9, 2023
mholtzman
reviewed
May 9, 2023
|
|
||
| expect(shortcuts).toStrictEqual({ | ||
| summon: { | ||
| modifierKeys: ['Alt', 'Control'], |
There was a problem hiding this comment.
is there a case on either platform where either of these modifiers could have already been in the list and we're left with a list like ['Alt', 'Control', 'Control']?
There was a problem hiding this comment.
Hmmm possibly, I'll address this.
There was a problem hiding this comment.
Ok it's not possible on Windows at least to get AltGr and either of the replacement modifiers in combination. Going to check linux
There was a problem hiding this comment.
I verified this on Linux, I couldn't get AltGr + Alt + ... to register - as soon as you press the left Alt key it overrides the AltGr.
mholtzman
reviewed
May 9, 2023
mholtzman
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.