Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow personal sign 20 byte messages #944

Merged
merged 1 commit into from
Jul 20, 2022
Merged

allow personal sign 20 byte messages #944

merged 1 commit into from
Jul 20, 2022

Conversation

mholtzman
Copy link
Collaborator

No description provided.

@mholtzman mholtzman linked an issue Jul 17, 2022 that may be closed by this pull request
Copy link
Contributor

@goosewobbler goosewobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mholtzman mholtzman merged commit ebc747e into beta.22 Jul 20, 2022
@mholtzman mholtzman deleted the correct-eth-sign branch July 20, 2022 07:42
mholtzman added a commit that referenced this pull request Jul 22, 2022
* version bump

* sentry asar munging data loss fix (#940)

Co-authored-by: goosewobbler <goosewobbler@pm.me>
Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com>

* Added a toggle for reporting logs via sentry (#938)

* Exception reporting added with toggle

Update index.js

* Adding missing set

* Error toggle fixup (#954)

* clean up implementation of error reporting toggle

* clean up filtering

* clean up UI

* add error handling and test for manual update check (#951)

* add error handling and test for manual update check

* resolve promise is newer version not found

* resolve with no update

* update prerelease track tests

* update test to reflect real response

* update status code

* allow personal sign 20 byte messages (#944)

* UX for revoking token spend approval (#953)

* UX for revoking token spend approval

* switch on new approval type

* revoke when amount is 0

* revoke handling

* ensure revoke is boolean

* first tests

* add revocation to approval onclick

* add snapshot tests, move around tests

* add snap

* standardise formatting

* move revoke out of state, clean up other prop use

* check converted hex

* revert to falsy approach for revoke

Co-authored-by: goosewobbler <goosewobbler@pm.me>

* add application closing logs

* upgrade Sentry SDK to v4.0.0-beta.1 (#956)

* upgrade eth-provider to v0.12.1 (#957)

* Correct token loading sequence, restart worker if not ready after 30 seconds (#958)

* add test for no connection when loading tokens

Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com>
Co-authored-by: goosewobbler <goosewobbler@pm.me>
Co-authored-by: Akihiko <105069903+0xakihiko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing 20-byte Message Doesn't Work
3 participants