UX for revoking token spend approval #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholtzman
commented
Jul 19, 2022
app/App/Panel/Main/Account/Requests/TransactionRequest/TxApproval/approvals/TokenSpend/index.js
Outdated
Show resolved
Hide resolved
mholtzman
commented
Jul 19, 2022
app/App/Panel/Main/Account/Requests/TransactionRequest/TxApproval/approvals/TokenSpend/index.js
Outdated
Show resolved
Hide resolved
|
can we center these buttons a little better instead of having them all the way at the edges w. lots of space in between?
|
I don't know about that. Firstly it looks fine to me, secondly it seems like unnecessary scope creep, especially in light of the reasons for not adjusting the UX in this panel as discussed @ sync yesterday. |
mholtzman
added a commit
that referenced
this pull request
Jul 22, 2022
* version bump * sentry asar munging data loss fix (#940) Co-authored-by: goosewobbler <goosewobbler@pm.me> Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com> * Added a toggle for reporting logs via sentry (#938) * Exception reporting added with toggle Update index.js * Adding missing set * Error toggle fixup (#954) * clean up implementation of error reporting toggle * clean up filtering * clean up UI * add error handling and test for manual update check (#951) * add error handling and test for manual update check * resolve promise is newer version not found * resolve with no update * update prerelease track tests * update test to reflect real response * update status code * allow personal sign 20 byte messages (#944) * UX for revoking token spend approval (#953) * UX for revoking token spend approval * switch on new approval type * revoke when amount is 0 * revoke handling * ensure revoke is boolean * first tests * add revocation to approval onclick * add snapshot tests, move around tests * add snap * standardise formatting * move revoke out of state, clean up other prop use * check converted hex * revert to falsy approach for revoke Co-authored-by: goosewobbler <goosewobbler@pm.me> * add application closing logs * upgrade Sentry SDK to v4.0.0-beta.1 (#956) * upgrade eth-provider to v0.12.1 (#957) * Correct token loading sequence, restart worker if not ready after 30 seconds (#958) * add test for no connection when loading tokens Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com> Co-authored-by: goosewobbler <goosewobbler@pm.me> Co-authored-by: Akihiko <105069903+0xakihiko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.