Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "Warning" level errors. #180

Closed
ajhyndman opened this issue Nov 6, 2017 · 4 comments
Closed

Show "Warning" level errors. #180

ajhyndman opened this issue Nov 6, 2017 · 4 comments

Comments

@ajhyndman
Copy link

Flow recently added support for optional lint rules with a configurable warning level.

It looks like the flow-for-vscodedoes not currently consume warning level feedback from the flow server to display.

This would be a great feature going forward.
@orta
Copy link
Contributor

orta commented Nov 6, 2017

Likely would come for mostly free with #150

@matchu
Copy link

matchu commented Jun 28, 2018

Did this end up happening? I just upgraded to latest Flow, and I'm noticing that messages for unused $FlowFixMe comments no longer appear in my VS Code output, presumably because it's now a warning-level message?

@matchu
Copy link

matchu commented Jun 28, 2018

I've activated the include_warnings setting in my .flowconfig file, and warnings now appear for me in VS Code as warnings. But the Flow docs seem to suggest that IDE integrations will generally show warnings without this flag needing to be enabled?

@Mayank1791989
Copy link
Contributor

fixed in #295.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orta @matchu @Mayank1791989 @ajhyndman