Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP Umbrella #243

Closed
6 of 9 tasks
thymikee opened this issue May 10, 2018 · 7 comments
Closed
6 of 9 tasks

LSP Umbrella #243

thymikee opened this issue May 10, 2018 · 7 comments

Comments

@thymikee
Copy link
Contributor

thymikee commented May 10, 2018

We're going to track LSP (Language Server Protocol) related stuff, so we can reach feature parity with current extension.

  • Monorepo support (Yarn workspaces)
  • VSCode workspaces support
  • Coverage with flow status
  • Go To Reference of values that are imported from modules without @flow (not sure if possible yet)
  • Make use of relatedInformation for richer diagnostics with Flow >=0.67 (PR LSP: make use of relatedInformation for richer diagnostics #258).
  • Integrate with current options
    • runOnEdit
    • runOnAllFiles

Nice to haves, but not sure if possible with @builtin TS disabled:

  • Intellisense features could we support through LSP? Right now, without the TS @builtin, there's no support for Rename Symbol, for instance.
  • Apparently the TS builtin extension is what provides inline documentation when hovering over values that have doc-block comments (i.e. /** foo */). Maybe this should just be broken out from the main TS @builtin so you can disable other TS features but keep the doc-block parsing feature? Otherwise I'm guessing flow-for-vscode would have to reimplement this.

cc @wbinnssmith @kpsroka @jslauthor @orta

@jslauthor
Copy link

Intellisense features could we support through LSP? Right now, without the TS @Builtin, there's no support for Rename Symbol, for instance.

😬 I wasn't aware of this limitation. Is there a way around this somehow? Intellisense was a big part of why we wanted to support this.

@minedeljkovic
Copy link
Contributor

Please add displaying flow status to the list (current extension supports that feature).
I find it essential for any large codebase where flow recheck is not instant.

@orta
Copy link
Contributor

orta commented May 10, 2018

Features like rename symbol work through the LSP for TS, so if there's a way to track IDs through flows internals then it should be feasible

@namuol
Copy link

namuol commented May 15, 2019

Related issue in the flow repo regarding supporting documentation fields in LSP: facebook/flow#7725

@goodmind
Copy link

Is this issue tracks usage with builtin extension disabled?

@Mayank1791989
Copy link
Contributor

You can create a separate issue for it.

@mroch
Copy link
Contributor

mroch commented Sep 20, 2021

jsdoc support was implemented upstream. I just checked that box off

@mroch mroch closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants