Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense doesn't work over remote ssh with useLSP=true #336

Closed
jarkonik opened this issue Jun 7, 2019 · 19 comments
Closed

Intellisense doesn't work over remote ssh with useLSP=true #336

jarkonik opened this issue Jun 7, 2019 · 19 comments

Comments

@jarkonik
Copy link

jarkonik commented Jun 7, 2019

Hover/autocomplete features don't work when using https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-ssh in lsp mode.

@minedeljkovic
Copy link
Contributor

minedeljkovic commented Jun 7, 2019

Definition, references, document symbols, rename do not work, also.
Diagnostics, however, does work.

Debug info seems ok:

[Info  - 11:49:01 - frontend/.flowconfig] {
  "flowconfig": "/home/ubuntu/frontend/.flowconfig",
  "flow": {
    "path": "/home/ubuntu/frontend/node_modules/flow-bin/flow-linux64-v0.100.0/flow",
    "version": "0.100.0"
  },
  "serverStatus": {
    "state": "idle",
    "message": "Flow: done recheck"
  }
}

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Jun 7, 2019

Enable "flow.trace.server": "verbose" and check for response of 'textDocument/hover' request (server trace will be logged in output > flow panel).

@jarkonik
Copy link
Author

jarkonik commented Jun 7, 2019

There are no 'textDocument/hover' requests present in the log at all.
I've also found out that everything works correctly using version 1.0.1 of the plugin(it is broken since 1.1.0).

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Jun 8, 2019

@jarkonik Can you share some sample project which is not working. I tried mine its working fine with v1.1.0. Is your plugin running what is showing up in status bar icon?.

@jarkonik
Copy link
Author

@Mayank1791989 Status bar displays flow version (0.93.0) (I've tried version 0.100 of flow too but it doesn't change anything) and coverage correctly. Even the "problems" tab is working ok - it displays all the flow type checking errors correctly.

// @flow
type MyType = {
    myField: string
};

function main() {
    const a: MyType = {
        myField: 'test'
    };
}

I've tried it with this code within a file named main.js in the project root directory and default .flowconfig file. Hovering over any of types/vars does not cause a popup to appear, IntelliSense shows only generic text-based autocompletion.

@Mayank1791989
Copy link
Contributor

@jarkonik any progress?

@jarkonik
Copy link
Author

@Mayank1791989 Are you sure you are not seeing builtin TypeScript extension autocomplete/hover data? I have tested it in multiple different environments and it never works.

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Jun 27, 2019

@jarkonik I always keep Typescript plugin disabled so I am sure that is not the case. Anyways I will test it again.

@Mayank1791989
Copy link
Contributor

It's working fine.

@minedeljkovic
Copy link
Contributor

@Mayank1791989 my team is using remote ssh extensively, and we are experiencing exact same symptoms as @jarkonik. It seems you are testing it differently

@ssenchenko
Copy link

the same issue with remote wsl

@ssenchenko
Copy link

also there are no type hints in remote wsl

@Mayank1791989
Copy link
Contributor

@ssenchenko Is plugin starting correctly? (Look at output > flow panel logs or status bar widget to find.)
Also enable "flow.trace.server": "verbose" to see lsp logs and look for request and response. It looks like some setup issue.

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Aug 2, 2019

@minedeljkovic Are you able to run the plugin? I tried again it's working for me. I am testing using linux machine for host and remote. Share your flow output panel logs.

@minedeljkovic
Copy link
Contributor

I am testing using linux machine for host and remote

That seems to be the difference! I'm regularly using windows host and linux remote (and, extremely likely, so is @jarkonik), and I just tried it on linux host and linux remote, and it does work.
So my experience is that on windows host extension does not fully work after version 1.0.1 (as described here, here and here). On linux host, the latest version seems to work 100%.

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Aug 2, 2019

@minedeljkovic Ok I will test with windows host and try to find issue.

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Aug 3, 2019

@minedeljkovic & @ssenchenko I found the issue will push the fix soon.

@jarkonik
Copy link
Author

@Mayank1791989 Seems that the issue reappeared again in vscode version 1.39.1

@romanlex
Copy link

romanlex commented May 13, 2020

I have same problem with flowtype and vscode remote WSL
on hover I don't see any types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants