Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Fix CRDT Map in array handling [LNG-370] #1171

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

InversionSpaces
Copy link
Contributor

@InversionSpaces InversionSpaces commented Jul 11, 2024

Description

Fix compiler failing on such code:

aqua Main

export main

func test(arr: []⊤) -> string:
  <- "test"

func main() -> string:
  map: %string
  <- test([map])

Proposed Changes

Make CollectibleType more strict.

Checklist

  • Corresponding issue has been created and linked in PR title.
  • Proposed changes are covered by tests.
  • Documentation has been updated to reflect the changes (if applicable).
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Jul 11, 2024

@InversionSpaces InversionSpaces added the e2e Run e2e workflow label Jul 11, 2024
@InversionSpaces InversionSpaces enabled auto-merge (squash) July 11, 2024 14:51
@InversionSpaces InversionSpaces merged commit b0f3a8c into main Jul 12, 2024
14 checks passed
@InversionSpaces InversionSpaces deleted the fix/LNG-370-map-in-array branch July 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants