feat(interface)!: Use MessagePack for calls #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top-level structs use multicodec-prefixed MessagePack, the nested structures (arguments, tetraplets) use just ordinary MessagePack.
monoid
added
P-high
It is important for JS interop and data compatiblity detection.
Binary format implementations like `rmp-serde` do not bother converting keys from strings, unlike `serde_json`. So, we do it manually for all formats, using CallResults with string keys.
raftedproc
reviewed
Dec 29, 2023
raftedproc
reviewed
Dec 29, 2023
raftedproc
reviewed
Dec 29, 2023
raftedproc
reviewed
Dec 29, 2023
mikevoronov
reviewed
Jan 3, 2024
crates/air-lib/interpreter-interface/src/call_service_result.rs
Outdated
Show resolved
Hide resolved
crates/air-lib/interpreter-interface/src/call_service_result.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Voronov <michail.vms@gmail.com>
Co-authored-by: Mike Voronov <michail.vms@gmail.com>
This reverts commit 4082dde.
monoid
force-pushed
the
feat/VM-397-binary-calls
branch
from
bf5d3b9
to
5b6c70a
Compare
It seems that certain services may depend on key ordering etc. Use JSON for a while for backward compatibility.
monoid
force-pushed
the
feat/VM-397-binary-calls
branch
from
5b6c70a
to
550fc69
Compare
It makes code simplier and consumes less memory for intermediate structures.
mikevoronov
approved these changes
Jan 7, 2024
crates/air-lib/interpreter-interface/src/call_service_result.rs
Outdated
Show resolved
Hide resolved
monoid
force-pushed
the
feat/VM-397-binary-calls
branch
from
0fd7a96
to
fe8c1fc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level structs use multicodec-prefixed MessagePack, the nested structures (arguments, tetraplets) use just ordinary MessagePack.
The old benchmark was against MessagePack version too, so the numbers haven't changed much.