Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): change default for the cpu range in nox #2140

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

gurinderu
Copy link
Contributor

Description

Changed the default behaviour for the cpu range

Motivation

Do not use kernel cores for the big machines.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@folex folex requested a review from mikevoronov March 8, 2024 13:01
@gurinderu gurinderu marked this pull request as ready for review March 8, 2024 13:01
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 8, 2024
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 8, 2024
@gurinderu gurinderu enabled auto-merge (squash) March 8, 2024 13:36
@folex folex disabled auto-merge March 8, 2024 13:37
@folex folex merged commit c976373 into master Mar 8, 2024
13 of 14 checks passed
@folex folex deleted the default_cpus_range branch March 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants