Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): custom log format [fixes NET-724 NET-725] #2218

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Apr 1, 2024

Description

Added a custom log format.

Motivation

Wants to format spans differently.

Related Issue(s)

NET-724
NET-725

Screenshots

Screenshot 2024-04-01 at 19 44 20

Additional Notes

  • Added non-blocking log appender

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Apr 1, 2024

@gurinderu gurinderu changed the title feat(log): custom log format feat(log): custom log format [fixes NET-724 NET-725] Apr 1, 2024
Copy link

linear bot commented Apr 1, 2024

@gurinderu gurinderu marked this pull request as ready for review April 1, 2024 16:52
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 1, 2024
@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Apr 1, 2024
@kmd-fl
Copy link
Contributor

kmd-fl commented Apr 2, 2024

Can you please explain the format in your screenshot?

@gurinderu
Copy link
Contributor Author

Can you please explain the format in your screenshot?

it is a default format with a custom spans format and the ability to hide the span list.

@kmd-fl
Copy link
Contributor

kmd-fl commented Apr 2, 2024

it is a default format with a custom spans format and the ability to hide the span list.

In your example, there are sometimes {peer_id = ""}, and sometimes there are not. I don't understand what is it, which peer id exactly and how do I add my custom data.

@gurinderu
Copy link
Contributor Author

In your example, there are sometimes {peer_id = ""}, and sometimes there are not. I don't understand what is it, which peer id exactly and how do I add my custom data.

ah, I got it. peer_id is the id passed inside current or parent spans. For now, you will see this information only in tests. It allows us to understand which node writes this line.

@gurinderu gurinderu merged commit 41faf0b into master Apr 4, 2024
21 checks passed
@gurinderu gurinderu deleted the feature/net-725 branch April 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants