-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network)!: Network isolation [fixes NET-818] #2245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
May 27, 2024
folex
reviewed
May 27, 2024
folex
reviewed
May 27, 2024
folex
reviewed
May 27, 2024
folex
reviewed
May 27, 2024
kmd-fl
reviewed
May 28, 2024
gurinderu
changed the title
feat(network): Network isolation
feat(network): Network isolation [fixes NET-818]
May 28, 2024
folex
reviewed
May 28, 2024
folex
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the Identify protocol handler API, LGTM.
gurinderu
changed the title
feat(network): Network isolation [fixes NET-818]
feat(network)!: Network isolation [fixes NET-818]
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a segregated kademlia protocol.
Motivation
It is possible to use a dar network from another network.
Related Issue(s)
NET-818
Proposed Changes
Introduced a schema with different kademlia protocols /fluence/kad/$id/1.0.0, where ID is the name of the network or custom ID for the private networking
Additional Notes
Checklist
Reviewer Checklist