Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-manager): add range check + clippy fixes #2250

Merged
merged 2 commits into from
May 20, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented May 20, 2024

Description

Forbid the case when the CPU range exceeds the real CPU count.

Additional notes

  • Updated CCP library
  • improved logging for the worker creation flow

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu added the e2e Run e2e workflow label May 20, 2024
@gurinderu gurinderu marked this pull request as ready for review May 20, 2024 11:41
@gurinderu gurinderu enabled auto-merge (squash) May 20, 2024 13:33
@gurinderu gurinderu merged commit a873a69 into master May 20, 2024
17 checks passed
@gurinderu gurinderu deleted the core-manager-range-check branch May 20, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants