Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VM): vm utils crate [fixes BRND-19] #2311

Merged
merged 17 commits into from
Jul 19, 2024
Merged

feat(VM): vm utils crate [fixes BRND-19] #2311

merged 17 commits into from
Jul 19, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Jul 15, 2024 •
edited
Loading

Description

Vm-utils crate for the simple VM creation

Related Issue(s)

BRND-19

Proposed Changes

I added a separate crate that allows the XML configuration to be prepared for the VM and created via libvirt.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Jul 15, 2024

BRND-19 Nox VM integration crate

mikevoronov
mikevoronov approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/vm-utils/Cargo.toml Outdated Show resolved Hide resolved
crates/vm-utils/src/vm_utils.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu added the e2e Run e2e workflow label Jul 15, 2024
@gurinderu gurinderu changed the title feat(VM): vm utils crate feat(VM): vm utils crate [fixes BRND-19] Jul 18, 2024
@gurinderu gurinderu marked this pull request as ready for review July 18, 2024 16:44
@gurinderu gurinderu merged commit d65466e into master Jul 19, 2024
14 checks passed
@gurinderu gurinderu deleted the feature/brnd-19 branch July 19, 2024 11:42
@fluencebot fluencebot mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmd-fl kmd-fl kmd-fl left review comments

@raftedproc raftedproc raftedproc left review comments

@mikevoronov mikevoronov mikevoronov approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gurinderu @mikevoronov @raftedproc @kmd-fl