fix(chain): prefix data with 0x in eth_calls #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justprosh
approved these changes
Jul 19, 2024
|
Where is the pr description? I don't understand why we needed that. |
gurinderu
approved these changes
Jul 22, 2024
folex
added a commit
that referenced
this pull request
Jul 24, 2024
* fix(chain): prefix data with 0x in eth_calls * chore: fmt * fix(hex): add 0x prefixes to topics * fix(hex): unify hex encoding * fix(test): use hex_utils in unit test * chore(doc): add docs for hex_utils functions * fix(tx): fix double 0x prefix * fix(deps): add hex to chain-connector tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Ethereum Spec https://eips.ethereum.org/EIPS/eip-1474#data, Data values must be prefixed with 0x.
Some blockchains – ie IPC – did allow us to pass it without
0xprefix, but others – ie Gelato – return an error in that case.This PR brings Nox one step closer to the ETH RPC spec. I will test it manually before merging.