-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: diamond config change + cleanup legacy [CHAIN-682] #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move subnet resolver to connector
justprosh
changed the title
feat!: diamond config change
feat!: diamond config change [CHAIN-682]
Aug 7, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't quite get the tests changes, otherwise LGTM
justprosh
changed the title
feat!: diamond config change [CHAIN-682]
feat!: diamond config change + cleanup legacy [CHAIN-682]
Aug 8, 2024
Co-authored-by: folex <0xdxdy@gmail.com>
kmd-fl
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
folex
reviewed
Aug 8, 2024
Co-authored-by: folex <0xdxdy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
diamond_contract_address
instead ofcore_contract_address
,cc_contract_address
andmarket_contract_address
network_api_endpoint
,network_id
,matcher_address
,start_block
,worker_gas
,wallet_key
pat_id
field tocu_ids
and changed type to vec (re multi CC update) in ResolveSubnetResult (fixed in feat!: change Worker type in SubnetResolveResult aqua-lib#88)FLUENCE_ENV_AQUA_IPFS_EXTERNAL_API_MULTIADDR
,FLUENCE_ENV_AQUA_IPFS_LOCAL_API_MULTIADDR
,FLUENCE_ENV_CONNECTOR_JOIN_ALL_DEALS
,FLUENCE_ENV_CONNECTOR_API_ENDPOINT
,FLUENCE_ENV_CONNECTOR_CONTRACT_ADDRESS
,FLUENCE_ENV_CONNECTOR_FROM_BLOCK
,FLUENCE_ENV_CONNECTOR_WALLET_KEY
,FLUENCE_ENV_DECIDER_IPFS_MULTIADDR
,FLUENCE_ENV_CONNECTOR_WORKER_GAS
Config changes
Before:
After:
Checklist
Reviewer Checklist