Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): prefix deal id with 0x in setWorker call #2348

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

folex
Copy link
Member

@folex folex commented Aug 12, 2024

Description

ETH RPC cannot process the call when DealId is used as an address without 0x

Failed host call "connector" "register_worker" ["7c6a93cdd24c98b07bc542cca7e1ec9e32f1b948","12D3KooWRq9mP27DmStaeduALdCE9exJS3x8Y3ikbESH8vasXNeY",["0b7ff07ad2cee1dc9a718991110f29745f597805ebb3b7aa22dd717f6e711c0d"]] (20ms 323us 348ns): "Failed to register worker: RPC call error: code: -32602, message: invalid argument 0: json: cannot unmarshal hex string without 0x prefix into Go struct field TransactionArgs.to of type common.Address, data:

Motivation

Gotta prefix addresses with 0x

Proposed Changes

Use DealId::to_address()

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@folex folex added the e2e Run e2e workflow label Aug 12, 2024
@kmd-fl kmd-fl merged commit 3ab2896 into master Aug 14, 2024
14 checks passed
@kmd-fl kmd-fl deleted the deal_address_0x branch August 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants