Fix a bug where output_status_num_errors metric is missing with Fluentd 1.14
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PND <fujjisaaan@gmail.com>
cosmo0920
approved these changes
Mar 18, 2022
|
Thanks! |
|
Thanks for fast responses! |
|
Are there any plans on releasing a new version soon with this fix included? |
|
Sorry, I forgot to release it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195
After the metrics mechanism change (#191), the
in_prometheus_output_monitorplugin tries to getnum_errorsmetric via thestatisticsmethod in the output plugin. This method, however, returns a hash containing thenum_errorsmetric as a keyretry_count, which causes the problem.This PR fixes
in_prometheus_output_monitorso that it finds theretry_countkey and set the value to theoutput_status_num_errorsmetric.