Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] sidecar.istio.io/inject: false use label instead of annotation #4418

Closed
fatedier opened this issue Nov 27, 2024 · 0 comments · Fixed by #4431, #4436, #4441, #4447 or #4457
Closed

[BUG] sidecar.istio.io/inject: false use label instead of annotation #4418

fatedier opened this issue Nov 27, 2024 · 0 comments · Fixed by #4431, #4436, #4441, #4447 or #4457
Labels
bug Something isn't working

Comments

@fatedier
Copy link

What is your environment(Kubernetes version, Fluid version, etc.)

Describe the bug

Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.

The annotation method was deprecated a long time ago, and the current approach might lead to unexpected issues during future Istio upgrades.

What you expect to happen:

Please follow the documentation to use the correct approach. https://istio.io/latest/docs/setup/additional-setup/sidecar-injection/#controlling-the-injection-policy

How to reproduce it

Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@fatedier