Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spoolman): improve sanity check logic #1411

Merged

Conversation

matmen
Copy link
Member

@matmen matmen commented Apr 9, 2024

Functional Changes:

  • Fixes file metadata retrieval
    (we might want to move this logic into SocketActions.serverFilesMetadata to ensure a consistent behavior?)
  • Fixes the printer state checks (sanity checks now only run when starting a print or changing the spool while an active print job is running)

Re-ordered some code for a clearer execution path

Closes #1408

Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen added the GH - Bug Something isn't working label Apr 9, 2024
@matmen matmen added this to the 1.29.2 milestone Apr 9, 2024
@matmen matmen requested a review from pedrolamas April 9, 2024 20:23
@matmen matmen merged commit 6930a24 into fluidd-core:develop Apr 11, 2024
4 checks passed
@matmen matmen deleted the fix/spoolman/unknown-filament-length branch April 11, 2024 08:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spoolman integration erroneously reports missing metadata
2 participants