Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol dragging on ios #749

Closed
martinsellergren opened this issue Nov 10, 2021 · 9 comments
Closed

Symbol dragging on ios #749

martinsellergren opened this issue Nov 10, 2021 · 9 comments
Labels

Comments

@martinsellergren
Copy link

On Android symbol dragging works just fine but on ios, nope (at least not for me). I guess it's not yet implemented for ios?

Related:
#130
mapbox/mapbox-annotation-extension#43

@martinsellergren
Copy link
Author

I looked at the code to see if maybe I could fix it and it seems, dragging is implemented in iOS(?) But still not working on my device. Could this be an issue with the underlaying iOS mapbox annotation library?

@kleeb
Copy link
Contributor

kleeb commented Nov 12, 2021

I feel that more features are not developed on iOS - linePattern for line styles (like dotted one) works only on Android

@lomza
Copy link

lomza commented Nov 12, 2021

Yes, seems like neither lines or circles can be dragged on iOS either.
Issues: #750
#186

@AAverin
Copy link
Contributor

AAverin commented Nov 19, 2021

I have found the cause but got no idea how to fix it.
Maybe some iOS expert can help?

mapView.addGestureRecognizer(longPress)

Adding a long-press handler breaks dragging functionality completely.
Removing this doesn't help

        for recognizer in mapView.gestureRecognizers! where recognizer is UILongPressGestureRecognizer {
            longPress.require(toFail: recognizer)
        }

I guess it's something about the order of events?
Still, I can see that another long-press handler in MGLAnnotaionLayerView is correctly called, but handleDragGesture in the same class doesn't get invoked if there is a long-press handler attached on the map.

@felix-ht
Copy link
Collaborator

This might be related to this old issue? #156

@AAverin
Copy link
Contributor

AAverin commented Nov 22, 2021

@felix-ht I don't think so. If I remove long press handler completely annotations become draggable. On ios long press is used to grab annotation before it starts dragging, probably some kind of events order conflict happens and pan/drag handler doesn't get invoked correctly

@stale
Copy link

stale bot commented Jan 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2022
@stale stale bot closed this as completed Jan 28, 2022
@tfvtti
Copy link

tfvtti commented Feb 14, 2022

I'd like to fix symbol dragging on iOS. My work zone design application really needs this. Is this issue actually well understood, it looks like some debugging is still needed. Have the APIs for flutter been fleshed out yet? Anyone have an informed opinion on what effort might be required to get dragging working properly on iOS? I need to give my boss an effort estimate in order to justify the time to work on this.

@felix-ht
Copy link
Collaborator

felix-ht commented Feb 14, 2022

its fixed on current master. The whole annotations part was completely rewritten in dart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants