From 45d5f702133e8c122e46ab14863a3f3df481c974 Mon Sep 17 00:00:00 2001 From: Ravi Mistry Date: Tue, 26 Mar 2019 16:46:32 -0400 Subject: [PATCH] Fix RecreateSKPs bot page sets II Both mobile SKPs of ebay/sfgate are not useful. We already have a desktop version of ebay. Create one for sfgate. NoTry: true Bug: skia:8653 Change-Id: I535c352d46d34500c2a8bdda12d406c58e16fd55 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203804 Reviewed-by: Ravi Mistry Commit-Queue: Ravi Mistry --- tools/skp/page_sets/skia_ebay_mobile.py | 40 ------------------- ...fgate_mobile.py => skia_sfgate_desktop.py} | 18 ++++----- 2 files changed, 9 insertions(+), 49 deletions(-) delete mode 100644 tools/skp/page_sets/skia_ebay_mobile.py rename tools/skp/page_sets/{skia_sfgate_mobile.py => skia_sfgate_desktop.py} (60%) diff --git a/tools/skp/page_sets/skia_ebay_mobile.py b/tools/skp/page_sets/skia_ebay_mobile.py deleted file mode 100644 index 075a1924100bb..0000000000000 --- a/tools/skp/page_sets/skia_ebay_mobile.py +++ /dev/null @@ -1,40 +0,0 @@ -# Copyright 2019 The Chromium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. -# pylint: disable=W0401,W0614 - - -from telemetry import story -from telemetry.page import page as page_module -from telemetry.page import shared_page_state - - -class SkiaMobilePage(page_module.Page): - - def __init__(self, url, page_set): - super(SkiaMobilePage, self).__init__( - url=url, - name=url, - page_set=page_set, - shared_page_state_class=shared_page_state.SharedMobilePageState) - self.archive_data_file = 'data/skia_ebay_mobile.json' - - def RunNavigateSteps(self, action_runner): - action_runner.Navigate(self.url) - action_runner.Wait(30) - - -class SkiaEbayMobilePageSet(story.StorySet): - """ Pages designed to represent the median, not highly optimized web """ - - def __init__(self): - super(SkiaEbayMobilePageSet, self).__init__( - archive_data_file='data/skia_ebay_mobile.json') - - urls_list = [ - # go/skia-skps-3-2019 - 'https://www.ebay.com/sch/i.html?_nkw=viking+helmet', - ] - - for url in urls_list: - self.AddStory(SkiaMobilePage(url, self)) diff --git a/tools/skp/page_sets/skia_sfgate_mobile.py b/tools/skp/page_sets/skia_sfgate_desktop.py similarity index 60% rename from tools/skp/page_sets/skia_sfgate_mobile.py rename to tools/skp/page_sets/skia_sfgate_desktop.py index 1b04d51c5cdfd..5c35d51aca31a 100644 --- a/tools/skp/page_sets/skia_sfgate_mobile.py +++ b/tools/skp/page_sets/skia_sfgate_desktop.py @@ -9,32 +9,32 @@ from telemetry.page import shared_page_state -class SkiaMobilePage(page_module.Page): +class SkiaDesktopPage(page_module.Page): def __init__(self, url, page_set): - super(SkiaMobilePage, self).__init__( + super(SkiaDesktopPage, self).__init__( url=url, name=url, page_set=page_set, - shared_page_state_class=shared_page_state.SharedMobilePageState) - self.archive_data_file = 'data/skia_sfgate_mobile.json' + shared_page_state_class=shared_page_state.SharedDesktopPageState) + self.archive_data_file = 'data/skia_sfgate_desktop.json' def RunNavigateSteps(self, action_runner): action_runner.Navigate(self.url) action_runner.Wait(30) -class SkiaSfgateMobilePageSet(story.StorySet): +class SkiaSfgateDesktopPageSet(story.StorySet): """ Pages designed to represent the median, not highly optimized web """ def __init__(self): - super(SkiaSfgateMobilePageSet, self).__init__( - archive_data_file='data/skia_sfgate_mobile.json') + super(SkiaSfgateDesktopPageSet, self).__init__( + archive_data_file='data/skia_sfgate_desktop.json') urls_list = [ # go/skia-skps-3-2019 - 'http://www.sfgate.com/', + 'http://www.sfgate.com/news/', ] for url in urls_list: - self.AddStory(SkiaMobilePage(url, self)) + self.AddStory(SkiaDesktopPage(url, self))