Preserve the alpha for VD content by setting a transparent background. #9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attempt to do this by setting the theme to Theme_Translucent_NoTitleBar was reported to offsetting touch events on specific Xiaomi devices.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2019
flutter/engine@66092d5...e3e4b26 git log 66092d5..e3e4b26 --no-merges --oneline e3e4b26 Roll fuchsia/sdk/core/mac-amd64 from pwsYtqWGHRP43dB0EyLu7S9R3uGV0dIhulPbnSUDUmcC to xJPmd7maxxcPRu9HpByelwYaqa-v6qipCfy6JhgYS9oC (flutter/engine#9858) 3233f94 Disable Fuchsia Debug & Release presubmits and only attempt the Profile unopt variant. (flutter/engine#9856) 6e1a3e8 Roll src/third_party/skia a3e2996b0834..947efe28de74 (6 commits) (flutter/engine#9853) 9eed783 Selectively enable tests that work on Windows and file issues for ones that don't. (flutter/engine#9852) 7ae3c3e Preserve the alpha for VD content by setting a transparent background. (flutter/engine#9849) a3926a3 Roll fuchsia/sdk/core/mac-amd64 from 94o0_NIcwi-V68SmUN4hU0fX5_JkMpPU5V8HaFvKWfYC to pwsYtqWGHRP43dB0EyLu7S9R3uGV0dIhulPbnSUDUmcC (flutter/engine#9848) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@66092d5...e3e4b26 git log 66092d5..e3e4b26 --no-merges --oneline e3e4b26 Roll fuchsia/sdk/core/mac-amd64 from pwsYtqWGHRP43dB0EyLu7S9R3uGV0dIhulPbnSUDUmcC to xJPmd7maxxcPRu9HpByelwYaqa-v6qipCfy6JhgYS9oC (flutter/engine#9858) 3233f94 Disable Fuchsia Debug & Release presubmits and only attempt the Profile unopt variant. (flutter/engine#9856) 6e1a3e8 Roll src/third_party/skia a3e2996b0834..947efe28de74 (6 commits) (flutter/engine#9853) 9eed783 Selectively enable tests that work on Windows and file issues for ones that don&flutter#39;t. (flutter/engine#9852) 7ae3c3e Preserve the alpha for VD content by setting a transparent background. (flutter/engine#9849) a3926a3 Roll fuchsia/sdk/core/mac-amd64 from 94o0_NIcwi-V68SmUN4hU0fX5_JkMpPU5V8HaFvKWfYC to pwsYtqWGHRP43dB0EyLu7S9R3uGV0dIhulPbnSUDUmcC (flutter/engine#9848) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to do this by setting the theme to
Theme_Translucent_NoTitleBar was reported to offsetting touch events on
specific Xiaomi devices.
This is an alternative approach to #9828 which is reported to offset touch events on some Xiaomi devices(#7236 (comment)).