Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Revert fixed keyboardDismissBehavior on scroll without a drag #161330

Closed
victorsanni opened this issue Jan 8, 2025 · 1 comment
Closed

[CP] Revert fixed keyboardDismissBehavior on scroll without a drag #161330

victorsanni opened this issue Jan 8, 2025 · 1 comment
Assignees
@christopherfujino
Labels
cp: review Cherry-picks in the review queue

Comments

@victorsanni
Copy link
Contributor

Issue Link

#160331

Target

stable

Cherry pick PR Link

#161329

Changelog Description

Using ScrollViewKeyboardDismissBehavior.onDrag in a SingleChildScrollView causes text fields to immediately unfocus if the keyboard opening scrolls the text field to keep it visible.

Impacted Users

Apps using text fields in a SingleChildScrollView.

Impact Description

Text fields are unusable within SingleChildScrollView.

Workaround

Disabling ScrollViewKeyboardDismissBehavior.

Risk

low

Test Coverage

yes

Validation Steps

No response
@victorsanni victorsanni added the cp: review Cherry-picks in the review queue label Jan 8, 2025
@victorsanni
Copy link
Contributor Author

cc @justinmc @Piinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christopherfujino christopherfujino

Labels
cp: review Cherry-picks in the review queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christopherfujino @victorsanni