New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow requesting a reduced widget tree with `getRootWidgetTree` service extension #157309

Merged

elliette merged 16 commits into flutter:master from elliette:smaller-widget-tree

Oct 23, 2024

Member

elliette commented Oct 21, 2024 •

edited

Loading

Work towards flutter/devtools#1423

Reduces the widget tree payload sent back from getRootWidgetTree when the fullDetails parameter is false.

getRootWidgetTree payload size comparison (for the Flutter gallery):

with fullDetails=true: 1,367,692 bytes
with fullDetails=false: 446,696 bytes

The fullDetails=false payload is approximately a third of the size of the original payload.

elliette added 9 commits

October 21, 2024 10:52


          Added method and doc

a916c0c


          Send minimal tree information to DevTools

72357f0


          Fix static analysis errors in tests

c9f4caa


          Add Widget Inspector test cases

0306e47


          format

4de6094


          Make fullDetails optional rather than required

d3ce544


          Some clean up

8abec43


          More clean up

02a0be7


          Add diagnostics test

e5be27c

elliette requested a review from kenzieschmoll

October 21, 2024 23:56

github-actions bot added the framework label


          Remove trailing whitespace

37d4776

kenzieschmoll reviewed

View reviewed changes

packages/flutter/lib/src/foundation/diagnostics.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/flutter/lib/src/foundation/diagnostics.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/flutter/lib/src/foundation/diagnostics.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/flutter/lib/src/foundation/diagnostics.dart Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/flutter/lib/src/foundation/diagnostics.dart Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/flutter/lib/src/widgets/widget_inspector.dart Outdated Show resolved Hide resolved

elliette added 2 commits

October 22, 2024 09:39


          Respond to PR comments

2c20904


          Merge branch 'master' into smaller-widget-tree

60164b9

elliette changed the title ~~Allow requesting an abbreviated widget tree with getRootWidgetTree service extension~~ Allow requesting a reduced widget tree with getRootWidgetTree service extension

kenzieschmoll approved these changes

View reviewed changes

elliette added 4 commits

October 22, 2024 10:40


          Update widget_inspector_test

11aa3f0


          Another test failure

5f754ed


          Merge branch 'master' into smaller-widget-tree

dc9c5aa


          Merge branch 'master' into smaller-widget-tree

72b2e0f

elliette merged commit 802bae0 into flutter:master

67 checks passed

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 4faa4a415ec9 to cc86b703ce5d (24 revisions) flutter/packages#7920

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

a0af557

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 4faa4a415ec9 to 25b55b9f2d09 (25 revisions) flutter/packages#7921

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

8fc15ed

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 4faa4a415ec9 to ef99fcbd60c5 (26 revisions) flutter/packages#7923

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

09c16d0

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 4faa4a415ec9 to bf319d621371 (28 revisions) flutter/packages#7924

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

e024485

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

91c3cb8

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

ddd1b5d

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

72aa1eb

…ree` service extension (flutter/flutter#157309)

elliette mentioned this pull request

[Inspector V2] Request the reduced widget tree from Flutter flutter/devtools#8480

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

7d5f1f2

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

0cae9ab

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

fddb6d0

…ree` service extension (flutter/flutter#157309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          802bae011 Allow requesting a reduced widget tree with `getRootWidgetT…

17e9de9

…ree` service extension (flutter/flutter#157309)

M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request


          Allow requesting a reduced widget tree with getRootWidgetTree servi…

93e96ab

…ce extension (flutter#157309)

elliette mentioned this pull request

[Widget Inspector] Fix stack overflow error for Flutter web when requesting a large widget tree #159454

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          [Widget Inspector] Fix stack overflow error for Flutter web when requ…

21bea32

…esting a large widget tree (#159454)

Fixes flutter/devtools#8553

Context: 

A Flutter web customer with a large widget tree was getting a stack
overflow error when they toggled on "show implementation widgets" in the
Flutter DevTools Inspector. This is because building the JSON tree
recursively was hitting Chrome's stack limit.

This PR creates the JSON tree **iteratively** if the `getRootWidgetTree`
service extension is called with `fullDetails = false` (which is what
DevTools uses to fetch the widget tree).

For all other instances of creating a widget JSON map (for example, when
fetching widget properties) the recursive implementation is used. This
allows properties provided by subclasses implementing `toJsonMap` to be
included in the response.

Note: Because with this change `toJsonMap` is only called when
`fullDetails = true` and `toJsonMapIterative` is only called when
`fullDetails = false`, this PR partially reverts the changes in
#157309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels