Skip to content

Commit

Permalink
[video_player] Update Pigeon for non-nullable generics (#7790)
Browse files Browse the repository at this point in the history
Updates the Pigeon definition to uses non-nullable generics now that it's possible.

In practice for this plugin it's currently a no-op: the only affected collection is passed from Dart to native, on the Dart side the source was already a `Map<String, String>`, and on the native side we are using languages without nullability support in generics (Java and Obj-C). However, doing this now eliminates tech debt, and will avoid problems if/when the native side switches to Kotlin/Swift.

On iOS, also removes a class that was accidentally left, unused, in the Pigeon definition file after an earlier update to that file. Current versions of Pigeon would generate that class even though it's not used, so removing it from the definition avoids changes to the generated code that would otherwise have been caused by the update.

Part of flutter/flutter#155891
  • Loading branch information
stuartmorgan authored Oct 4, 2024
1 parent f142461 commit aa741d1
Show file tree
Hide file tree
Showing 15 changed files with 1,026 additions and 690 deletions.
4 changes: 4 additions & 0 deletions packages/video_player/video_player_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.7.8

* Updates Pigeon for non-nullable collection type support.

## 2.7.7

* Removes the flag to treat warnings as errors in client builds.
Expand Down
Loading

0 comments on commit aa741d1

Please sign in to comment.