Revert "Roll Flutter from c85fa6abf4ff to 7eebe2992aba (#6836)" #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
added
the
warning: land on red to fix tree breakage
camsim99
approved these changes
Jun 3, 2024
|
Do we know what code specifically is at issue? |
|
@reidbaker the tests are failing in Firebase Test Lab (application crashed), where the following packages had errors: A copy of one of the FTL stack traces (they all look similar-ish): Digging in the ADB logs, searching for "Fatal": Sooo... the Platform View for the Google Maps example/integration test app is not being initialized correctly? |
|
(If this is a change in the google maps SDK, this revert may also fail. Waiting for the results of "Linux_android android_device_tests_shard_2 master" in the presubmit of this PR before landing anything) |
What I am hearing from this message is NO. Something in the hash is bad but we dont know what. |
@reidbaker let me try to bisect to a more specific framework revision. |
|
My comment should not block this pr. I was just trying to get more actionable information in this pr if it was known. The links to evidence were good and the pr technically said what went wrong but I know if it was a submodule that was at fault we likely have another pr to roll back. |
|
@reidbaker yep, I'll try to land this as soon as tests pass to get the tree back to green, the bisection may just be useful for the fix. Do check the OG issue linked in the description of the PR, this might be an old issue that is now being consistently triggered by our maps example app! (More recent reports of the issue start around here: flutter/flutter#125090 (comment)) ((I'll also try to roll forward to a newer hash, in case the fix has landed, or maps rolled back whatever we were tickling)) |
|
BTW the issue for that error is flutter/flutter#125090 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2024
flutter/packages@11e192a...586faa6 2024-06-05 ditman@gmail.com [google_sign_in_web] Update button_tester to use web_only library. (flutter/packages#6868) 2024-06-05 engine-flutter-autoroll@skia.org Roll Flutter from c246ecd to 27e0656 (17 revisions) (flutter/packages#6875) 2024-06-05 15619084+vashworth@users.noreply.github.com [path_provider] Skip verifying sample file on macOS (flutter/packages#6874) 2024-06-05 joonas.kerttula@codemate.com [google_maps_flutter] Custom marker size improvements (flutter/packages#4055) 2024-06-05 uberchilly@gmail.com [rfw] Material slider widget (flutter/packages#6610) 2024-06-04 ditman@gmail.com [ci] Manual roll Flutter to c246ecd (84 revisions) + fixes (flutter/packages#6863) 2024-06-04 molchanovia.dev@gmail.com Correcting the typo of Flutter in projects (flutter/packages#6850) 2024-06-04 joonas.kerttula@codemate.com [google_maps_flutter] Custom marker size improvements - platform impls (flutter/packages#6826) 2024-06-04 lrn@google.com Avoid cumbersome formatter workaround (flutter/packages#6573) 2024-06-04 15619084+vashworth@users.noreply.github.com Clean Xcode project before analyzing and testing (flutter/packages#6842) 2024-06-03 37848204+RobinCombrink@users.noreply.github.com [pigeon] Kotlin/Java method overloading for the `setUp` method (flutter/packages#6843) 2024-06-03 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add support for setting show title on Chrome Custom Tabs (flutter/packages#6097) 2024-06-03 ditman@gmail.com Revert "Roll Flutter from c85fa6a to 7eebe29 (#6836)" (flutter/packages#6860) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…#6860) This reverts commit 11e192a. Revert "Roll Flutter from c85fa6a to 7eebe29 (26 revisions) (flutter#6836)" Because of Issue: * flutter/flutter#125090 Example of broken build: * https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20android_device_tests_shard_2%20master/1089/overview (there's 7 retries)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 11e192a.
Revert "Roll Flutter from c85fa6a to 7eebe29 (26 revisions) (#6836)"
Because of Issue:
Example of broken build:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.