Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary breaks in default clauses of switch statements #7462

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Remove unnecessary breaks in default clauses of switch statements #7462

merged 1 commit into from
Aug 21, 2024

Conversation

jason-simmons
Copy link
Member

@jason-simmons
Copy link
Member Author

@stuartmorgan Does this require incrementing any package version numbers?

Or should I add the override labels?

@stuartmorgan
Copy link
Contributor

Usually we err on the side of releasing anything that changes code, but this is very clearly a no-op so it's fine to override.

@stuartmorgan stuartmorgan added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 21, 2024
@stuartmorgan
Copy link
Contributor

Override changelog and version: While technically a code change, this is a no-op behaviorally.

stuartmorgan
stuartmorgan approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cbracken
cbracken approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2024
@auto-submit auto-submit bot merged commit 2703d10 into flutter:main Aug 21, 2024
76 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 21, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 21, 2024
@engine-flutter-autoroll
2703d10 Remove unnecessary breaks in default clauses of switch statem…
fb5f5ef 
…ents (flutter/packages#7462)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 21, 2024
@engine-flutter-autoroll
Roll Packages from 4e5d47e to c5d03ee (2 revisions) (#153865)
503f0f8 
flutter/packages@4e5d47e...c5d03ee

2024-08-21 34871572+gmackall@users.noreply.github.com [many] Remove dependency on `kotlin-bom` (flutter/packages#7088)
2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7462)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from 4e5d47e to c5d03ee (2 revisions) (flutter#153865)
ef9191b 
flutter/packages@4e5d47e...c5d03ee

2024-08-21 34871572+gmackall@users.noreply.github.com [many] Remove dependency on `kotlin-bom` (flutter/packages#7088)
2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7462)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

@matanlurey matanlurey matanlurey approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@jmagman jmagman Awaiting requested review from jmagman jmagman is a code owner

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera p: go_router p: rfw Remote Flutter Widgets p: url_launcher p: webview_flutter platform-android platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jason-simmons @stuartmorgan @matanlurey @cbracken