[various] Update Swift plugins for non-nullable generics #7742
Conversation
stuartmorgan
requested review from
cbracken,
tarrinneal and
jmagman
as code owners
| required this.allowsMultipleSelection, | ||
| required this.canChooseDirectories, | ||
| required this.canChooseFiles, | ||
| required this.baseOptions, |
There was a problem hiding this comment.
Since this change is non-obvious: Pigeon used to basically discard the constructor, so none of this mattered. With the update:
- some code failed analysis because it was passing default values, and I decided I preferred having the call site across the Pigeon boundary be very explicit about the settings in each method, and
- the
const SavePanelOptions()didn't compile because const-ness isn't preserved into the Pigeon-generated Dart code.
There was a problem hiding this comment.
is const-ness something we'd like?
There was a problem hiding this comment.
Could be worth considering, since having data classes be unmodifiable is often useful. It would add some complexity to native generators though since we'd need to make setters conditionally generated.
|
I can split this into three PRs if folks prefer, I just figured since we get more compiler support for the change with Swift, there aren't too many, and they are relatively small, I'd try batching them. |
stuartmorgan
force-pushed
the
pigeon-non-null-update-swift
branch
from
2ccc25f to
2e01a36
Compare
| required this.allowsMultipleSelection, | ||
| required this.canChooseDirectories, | ||
| required this.canChooseFiles, | ||
| required this.baseOptions, |
There was a problem hiding this comment.
is const-ness something we'd like?
I'll let you know once I see whether any regression issues are filed 😅 But it was easy to update. With strongly typed generic enforcement on both sides, the compilers did most of the work for me. |
stuartmorgan
added
the
autosubmit
flutter/packages@429650f...05bf1d4 2024-10-04 stuartmorgan@google.com [various] Update Swift plugins for non-nullable generics (flutter/packages#7742) 2024-10-04 stuartmorgan@google.com [url_launcher] Update Android Pigeon (flutter/packages#7744) 2024-10-04 22963120+Craftplacer@users.noreply.github.com [xdg_directories] Add `stateHome` property (flutter/packages#7766) 2024-10-03 stuartmorgan@google.com [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781) 2024-10-03 cedvandenbosch@gmail.com [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates Swift-based plugins to the current version of Pigeon:
These are done as a batch since the Swift plugins are unusual among our plugins in having strong typing changes on the native side, making them easier to do mechanically.
Part of flutter/flutter#155891
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).