-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[file_selector] Update Android Pigeon for non-nullable generics #7781
[file_selector] Update Android Pigeon for non-nullable generics #7781
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
test-exempt: code refactor with no semantic change |
flutter/packages@429650f...05bf1d4 2024-10-04 stuartmorgan@google.com [various] Update Swift plugins for non-nullable generics (flutter/packages#7742) 2024-10-04 stuartmorgan@google.com [url_launcher] Update Android Pigeon (flutter/packages#7744) 2024-10-04 22963120+Craftplacer@users.noreply.github.com [xdg_directories] Add `stateHome` property (flutter/packages#7766) 2024-10-03 stuartmorgan@google.com [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781) 2024-10-03 cedvandenbosch@gmail.com [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Removes workarounds for previous lack of non-nullable generics support. There are no native code changes because in practice we already didn't want nullable values in the collection, we just couldn't express it formally.
Part of flutter/flutter#155891
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).