Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file_selector] Update Android Pigeon for non-nullable generics #7781

Merged

Conversation

stuartmorgan
Copy link
Contributor

Removes workarounds for previous lack of non-nullable generics support. There are no native code changes because in practice we already didn't want nullable values in the collection, we just couldn't express it formally.

Part of flutter/flutter#155891

Pre-launch Checklist

@stuartmorgan stuartmorgan requested a review from gmackall as a code owner October 3, 2024 18:25
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan
Copy link
Contributor Author

test-exempt: code refactor with no semantic change

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit auto-submit bot merged commit 9e7333d into flutter:main Oct 3, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 4, 2024
flutter/packages@429650f...05bf1d4

2024-10-04 stuartmorgan@google.com [various] Update Swift plugins for non-nullable generics (flutter/packages#7742)
2024-10-04 stuartmorgan@google.com [url_launcher] Update Android Pigeon (flutter/packages#7744)
2024-10-04 22963120+Craftplacer@users.noreply.github.com [xdg_directories] Add `stateHome` property (flutter/packages#7766)
2024-10-03 stuartmorgan@google.com [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781)
2024-10-03 cedvandenbosch@gmail.com [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: file_selector platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants