[various] Update Java compatibility version to 11 #7795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested review from
bparrishMines,
camsim99,
matanlurey,
gmackall,
reidbaker,
tarrinneal,
Piinks,
Hixie,
chunhtai,
gspencergoog and
ditman
as code owners
github-actions
bot
added
p: extension_google_sign_in_as_googleapis_auth
p: pigeon
p: flutter_image
p: rfw
github-actions
bot
added
p: path_provider
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
matanlurey
approved these changes
Oct 4, 2024
reidbaker
approved these changes
Oct 4, 2024
gmackall
approved these changes
Oct 4, 2024
stuartmorgan
added
the
autosubmit
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 7, 2024
flutter/packages@05bf1d4...bb00d34 2024-10-07 stuartmorgan@google.com [google_sign_in] Update Pigeon for non-nullable generics (flutter/packages#7785) 2024-10-07 stuartmorgan@google.com [path_provider] Update Android Pigeon for non-nullable generics (flutter/packages#7783) 2024-10-07 victoreronmosele@gmail.com [rfw] Increase tolerance for material widget tests (flutter/packages#7148) 2024-10-05 stuartmorgan@google.com [various] Update Java compatibility version to 11 (flutter/packages#7795) 2024-10-04 stuartmorgan@google.com [video_player] Update Pigeon for non-nullable generics (flutter/packages#7790) 2024-10-04 tobias@leafnode.se [go_router] Added missing implementation for the routerNeglect parameter in GoRouter (flutter/packages#7752) 2024-10-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Convert `BitmapDescriptor` to typesafe subclasses (flutter/packages#7699) 2024-10-04 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Convert `PatternItem` and `Cap` to typesafe structures. (flutter/packages#7703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2024
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1. See also flutter/packages#7795 which made this change in Flutter-team-owned plugins. Part of #156111
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Oct 17, 2024
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1. See also flutter/packages#7795 which made this change in Flutter-team-owned plugins. Part of flutter#156111
eyebrowsoffire
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Nov 13, 2024
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1. See also flutter/packages#7795 which made this change in Flutter-team-owned plugins. Part of flutter#156111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
stablerequires AGP 7.0, which in turn requires Java 11+, we should be able to set our compatibility version to 11 (setting the min Flutter SDK version to current stable).Also removes the gradle conditionals for setting namespace (and the repo tool checks that it is present), as that was only needed for AGP 4.1 compatibility.
Part of flutter/flutter#156111
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).