Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual roll Flutter from fa402c8057a1 to ead6b0d17c89 (14 revisions) #7806

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
39fe9d2
a0e75cd30 remove fujino from CODEOWNERS (flutter/flutter#155369)
engine-flutter-autoroll Oct 7, 2024
1b6b19d
20bc0a9cb Fix line-wrapping in `flutter create` error message. (flutt…
engine-flutter-autoroll Oct 7, 2024
3f1a0e7
feb9c5928 Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 re…
engine-flutter-autoroll Oct 7, 2024
0da6674
7f663fc1d Fix broken text field with set hint and min and max lines(#…
engine-flutter-autoroll Oct 7, 2024
9862a25
9a64920bb `RenderParagraph` should invalidate its `_SelectableFragmen…
engine-flutter-autoroll Oct 7, 2024
a529297
2c0a4f2d4 Use flutter from in same repo (not path) in `generate_gradl…
engine-flutter-autoroll Oct 7, 2024
9ce3d52
5b32f3327 Use flutter from in same repo (not path) in `generate_gradl…
engine-flutter-autoroll Oct 7, 2024
4048ac3
799cf16ae fix: SelectableText should handle focus changes (flutter/fl…
engine-flutter-autoroll Oct 7, 2024
ebae2cf
cad7418f0 Roll packages manually (flutter/flutter#155786)
engine-flutter-autoroll Oct 7, 2024
d570fa1
f9a76aea8 Throw StateError when implicitView is null on `wrapWithDefa…
engine-flutter-autoroll Oct 7, 2024
5478d5e
7bb935291 Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 re…
engine-flutter-autoroll Oct 7, 2024
f13be83
9ee3fb813 Fix DropdownMenu rendered behind AppBar (flutter/flutter#15…
engine-flutter-autoroll Oct 7, 2024
b0767df
9be22b58c Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 re…
engine-flutter-autoroll Oct 7, 2024
dae7126
ead6b0d17 Remove left-over traces of "link-dry-run" - which isn't use…
engine-flutter-autoroll Oct 7, 2024
54335e8
Suppress warning, as with video_player_android
stuartmorgan Oct 7, 2024
a975fcb
Suppress warning in tests as well
stuartmorgan Oct 7, 2024
bd61b88
And in camera tests
stuartmorgan Oct 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
fa402c8057a11481b834c478cb8374df9bbc0819
ead6b0d17c893109b9424aaf116a74295472cc73
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ public void onSurfaceRequested(@NonNull SurfaceRequest request) {
surfaceProducer.setCallback(
new TextureRegistry.SurfaceProducer.Callback() {
@Override
// TODO(matanlurey): Replace with onSurfaceAvailable once available on stable;
// https://github.com/flutter/flutter/issues/155131.
@SuppressWarnings({"deprecation", "removal"})
public void onSurfaceCreated() {
// Do nothing. The Preview.SurfaceProvider will handle this whenever a new
// Surface is needed.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void createSurfaceProducer_setsExpectedSurfaceProducerCallback() {
reset(mockSurfaceRequest);

// Verify callback's onSurfaceCreated does not interact with the SurfaceRequest.
callback.onSurfaceCreated();
simulateSurfaceCreation(callback);
verifyNoMoreInteractions(mockSurfaceRequest);
}

Expand Down Expand Up @@ -262,4 +262,12 @@ public void setTargetRotation_makesCallToSetTargetRotation() {

verify(mockPreview).setTargetRotation(targetRotation);
}

// TODO(matanlurey): Replace with inline calls to onSurfaceAvailable once
// available on stable; see https://github.com/flutter/flutter/issues/155131.
// This seperate method only exists to scope the suppression.
@SuppressWarnings({"deprecation", "removal"})
void simulateSurfaceCreation(TextureRegistry.SurfaceProducer.Callback producerLifecycle) {
producerLifecycle.onSurfaceCreated();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ public void onSurfaceProducerDestroyedAndRecreatedReleasesAndThenRecreatesAndRes

// Create a new mock exo player so that we get a new instance.
mockExoPlayer = mock(ExoPlayer.class);
producerLifecycle.onSurfaceCreated();
simulateSurfaceCreation(producerLifecycle);

verify(mockExoPlayer).seekTo(10L);
verify(mockExoPlayer).setRepeatMode(Player.REPEAT_MODE_ALL);
Expand Down Expand Up @@ -231,7 +231,7 @@ public void onSurfaceCreatedDoesNotSendInitializeEventAgain() {

// Trigger destroyed/created.
producerLifecycle.onSurfaceDestroyed();
producerLifecycle.onSurfaceCreated();
simulateSurfaceCreation(producerLifecycle);

// Initial listener, and the new one from the resume.
verify(mockExoPlayer, times(2)).addListener(listenerCaptor.capture());
Expand All @@ -257,7 +257,7 @@ public void onSurfaceCreatedWithoutDestroyDoesNotRecreate() {
TextureRegistry.SurfaceProducer.Callback producerLifecycle = callbackCaptor.getValue();

// Calling onSurfaceCreated does not do anything, since the surface was never destroyed.
producerLifecycle.onSurfaceCreated();
simulateSurfaceCreation(producerLifecycle);
verifyNoMoreInteractions(mockProducer);

videoPlayer.dispose();
Expand All @@ -271,4 +271,12 @@ public void disposeReleasesTextureAndPlayer() {
verify(mockProducer).release();
verify(mockExoPlayer).release();
}

// TODO(matanlurey): Replace with inline calls to onSurfaceAvailable once
// available on stable; see https://github.com/flutter/flutter/issues/155131.
// This seperate method only exists to scope the suppression.
@SuppressWarnings({"deprecation", "removal"})
void simulateSurfaceCreation(TextureRegistry.SurfaceProducer.Callback producerLifecycle) {
producerLifecycle.onSurfaceCreated();
}
}