Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[path_parsing] deprecate utility functions that should be private #7993

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[path_parsing] deprecate utility functions that should be private #7993

merged 2 commits into from
Nov 1, 2024

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Nov 1, 2024 •
edited
Loading

@kevmoo kevmoo requested a review from domesticmouse as a code owner November 1, 2024 02:46
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

stuartmorgan
stuartmorgan reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other library_private_types_in_public_api violations in this file, including others using this type; it seems like it would make more sense to fix all of them at once rather than a series of deprecations.

third_party/packages/path_parsing/CHANGELOG.md Outdated Show resolved Hide resolved
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 1, 2024

Did see the other ones. Happy to fix, if there are straight forward

@stuartmorgan
Copy link
Contributor

test-exempt: code refactor with no semantic change

stuartmorgan
stuartmorgan approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2024
@auto-submit auto-submit bot merged commit 3c3181c into main Nov 1, 2024
76 checks passed
@auto-submit auto-submit bot deleted the path_parsing_deprecations branch November 1, 2024 17:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2024
@engine-flutter-autoroll
3c3181c2c [path_parsing] deprecate utility functions that should be p…
c001852 
…rivate (flutter/packages#7993)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2024
@engine-flutter-autoroll
3c3181c2c [path_parsing] deprecate utility functions that should be p…
671f867 
…rivate (flutter/packages#7993)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2024
@engine-flutter-autoroll
3c3181c2c [path_parsing] deprecate utility functions that should be p…
c68c8a7 
…rivate (flutter/packages#7993)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 4, 2024
@engine-flutter-autoroll
3c3181c2c [path_parsing] deprecate utility functions that should be p…
13fa046 
…rivate (flutter/packages#7993)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
@engine-flutter-autoroll
3c3181c2c [path_parsing] deprecate utility functions that should be p…
8487d18 
…rivate (flutter/packages#7993)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
@engine-flutter-autoroll
3c3181c2c [path_parsing] deprecate utility functions that should be p…
fa9f6f8 
…rivate (flutter/packages#7993)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 5, 2024
@engine-flutter-autoroll
Roll Packages from 796afa35071d to 721943194945 (11 revisions) (#158179)
49a16fc 
flutter/packages@796afa3...7219431

2024-11-05 jonahwilliams@google.com [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg  (flutter/packages#8018)
2024-11-04 kallentu@google.com [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter/packages#6473)
2024-11-04 stuartmorgan@google.com [various] Update example apps to Kotlin 1.9.0 (flutter/packages#7998)
2024-11-04 cedvandenbosch@gmail.com [go_router] add current state getter (flutter/packages#7651)
2024-11-04 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter/packages#7968)
2024-11-04 engine-flutter-autoroll@skia.org Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter/packages#8015)
2024-11-04 stuartmorgan@google.com [camera_windows] Revert: Support image streams on Windows platform (flutter/packages#7951)
2024-11-02 stuartmorgan@google.com [camera] Use Pigeon for Windows C++->Dart (flutter/packages#8001)
2024-11-02 kevmoo@users.noreply.github.com [script/tool] update dependencies (flutter/packages#7992)
2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter from 0fe6153 to f86b777 (16 revisions) (flutter/packages#8000)
2024-11-01 kevmoo@users.noreply.github.com [path_parsing] deprecate utility functions that should be private (flutter/packages#7993)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: path_parsing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @stuartmorgan @domesticmouse