From 7e580bd7855d2df688fc2e3e2b9dcb9607ac5a82 Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Thu, 16 Apr 2020 16:32:58 -0700 Subject: [PATCH 1/3] [video_player_web] Add a custom analysis_options file to video_player_web so the tree becomes green again. --- .../video_player_web/analysis_options.yaml | 10 ++++++++++ script/incremental_build.sh | 1 + 2 files changed, 11 insertions(+) create mode 100644 packages/video_player/video_player_web/analysis_options.yaml diff --git a/packages/video_player/video_player_web/analysis_options.yaml b/packages/video_player/video_player_web/analysis_options.yaml new file mode 100644 index 000000000000..f20e303802bc --- /dev/null +++ b/packages/video_player/video_player_web/analysis_options.yaml @@ -0,0 +1,10 @@ +# This is a temporary file to allow us to land a new set of linter rules in a +# series of manageable patches instead of one gigantic PR. It disables some of +# the new lints that are already failing on this plugin, for this plugin. It +# should be deleted and the failing lints addressed as soon as possible. + +include: ../../../analysis_options.yaml + +analyzer: + errors: + undefined_prefixed_name: ignore diff --git a/script/incremental_build.sh b/script/incremental_build.sh index 9534d62ac341..2aff859cbe34 100755 --- a/script/incremental_build.sh +++ b/script/incremental_build.sh @@ -16,6 +16,7 @@ source "$SCRIPT_DIR/common.sh" CUSTOM_ANALYSIS_PLUGINS=( "in_app_purchase" "camera" + "video_player_web" ) # Comma-separated string of the list above readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}") From 47c656593932a27a766b9337694c16bc97247da7 Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Thu, 16 Apr 2020 16:48:29 -0700 Subject: [PATCH 2/3] Bump version and changelog. --- packages/video_player/video_player_web/CHANGELOG.md | 4 ++++ packages/video_player/video_player_web/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player_web/CHANGELOG.md b/packages/video_player/video_player_web/CHANGELOG.md index 00fc486131bf..77a4e868b07d 100644 --- a/packages/video_player/video_player_web/CHANGELOG.md +++ b/packages/video_player/video_player_web/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.1.2+2 + +* Add `analysis_options.yaml` to the package, so we can ignore `undefined_prefixed_name` errors (temporarily). + ## 0.1.2+1 * Make the pedantic dev_dependency explicit. diff --git a/packages/video_player/video_player_web/pubspec.yaml b/packages/video_player/video_player_web/pubspec.yaml index e1435c893b8a..7cf036ef5b4b 100644 --- a/packages/video_player/video_player_web/pubspec.yaml +++ b/packages/video_player/video_player_web/pubspec.yaml @@ -1,7 +1,7 @@ name: video_player_web description: Web platform implementation of video_player homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web -version: 0.1.2+1 +version: 0.1.2+2 flutter: plugin: From ffa45a5fcfaa2a677b0d4a4071c73e2d6bf16b52 Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Thu, 16 Apr 2020 17:06:41 -0700 Subject: [PATCH 3/3] Address PR feedback. --- packages/video_player/video_player_web/CHANGELOG.md | 2 +- .../video_player/video_player_web/analysis_options.yaml | 8 ++++---- script/incremental_build.sh | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/video_player/video_player_web/CHANGELOG.md b/packages/video_player/video_player_web/CHANGELOG.md index 77a4e868b07d..f5408fa636ce 100644 --- a/packages/video_player/video_player_web/CHANGELOG.md +++ b/packages/video_player/video_player_web/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.1.2+2 -* Add `analysis_options.yaml` to the package, so we can ignore `undefined_prefixed_name` errors (temporarily). +* Add `analysis_options.yaml` to the package, so we can ignore `undefined_prefixed_name` errors. Works around https://github.com/flutter/flutter/issues/41563. ## 0.1.2+1 diff --git a/packages/video_player/video_player_web/analysis_options.yaml b/packages/video_player/video_player_web/analysis_options.yaml index f20e303802bc..443b16551ec9 100644 --- a/packages/video_player/video_player_web/analysis_options.yaml +++ b/packages/video_player/video_player_web/analysis_options.yaml @@ -1,7 +1,7 @@ -# This is a temporary file to allow us to land a new set of linter rules in a -# series of manageable patches instead of one gigantic PR. It disables some of -# the new lints that are already failing on this plugin, for this plugin. It -# should be deleted and the failing lints addressed as soon as possible. +# This is a temporary file to allow us to unblock the flutter/plugins repo CI. +# It disables some of lints that were disabled inline. Disabling lints inline +# is no longer possible, so this file is required. +# TODO(ditman) https://github.com/flutter/flutter/issues/55000 (clean this up) include: ../../../analysis_options.yaml diff --git a/script/incremental_build.sh b/script/incremental_build.sh index 2aff859cbe34..3b0b97f0dbe6 100755 --- a/script/incremental_build.sh +++ b/script/incremental_build.sh @@ -16,7 +16,7 @@ source "$SCRIPT_DIR/common.sh" CUSTOM_ANALYSIS_PLUGINS=( "in_app_purchase" "camera" - "video_player_web" + "video_player/video_player_web" ) # Comma-separated string of the list above readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")