From a9155915453ed125c2fab2fa7c2dee7e1d78ca7d Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Wed, 11 May 2022 17:27:01 -0700 Subject: [PATCH 1/3] [ios_platform_images] Ignore ImageProvider.load deprecation, so the framework can land it. --- packages/ios_platform_images/CHANGELOG.md | 5 +++++ packages/ios_platform_images/lib/ios_platform_images.dart | 1 + packages/ios_platform_images/pubspec.yaml | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/ios_platform_images/CHANGELOG.md b/packages/ios_platform_images/CHANGELOG.md index cf2632feaac7..7f2e78569134 100644 --- a/packages/ios_platform_images/CHANGELOG.md +++ b/packages/ios_platform_images/CHANGELOG.md @@ -1,3 +1,8 @@ +## 0.2.0+7 + +* Ignore deprecation of `load` method in [ImageProvider] so it can be + deprecated at the framework level, without breaking CI. + ## 0.2.0+6 * Removes unnecessary imports. diff --git a/packages/ios_platform_images/lib/ios_platform_images.dart b/packages/ios_platform_images/lib/ios_platform_images.dart index 4064fb312506..fc08d77ea8f1 100644 --- a/packages/ios_platform_images/lib/ios_platform_images.dart +++ b/packages/ios_platform_images/lib/ios_platform_images.dart @@ -64,6 +64,7 @@ class _FutureMemoryImage extends ImageProvider<_FutureMemoryImage> { /// See [ImageProvider.load]. @override + // ignore:deprecated_member_use ImageStreamCompleter load(_FutureMemoryImage key, DecoderCallback decode) { return _FutureImageStreamCompleter( codec: _loadAsync(key, decode), diff --git a/packages/ios_platform_images/pubspec.yaml b/packages/ios_platform_images/pubspec.yaml index 41a177560299..ddc02e6235db 100644 --- a/packages/ios_platform_images/pubspec.yaml +++ b/packages/ios_platform_images/pubspec.yaml @@ -2,7 +2,7 @@ name: ios_platform_images description: A plugin to share images between Flutter and iOS in add-to-app setups. repository: https://github.com/flutter/plugins/tree/main/packages/ios_platform_images issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+ios_platform_images%22 -version: 0.2.0+6 +version: 0.2.0+7 environment: sdk: ">=2.14.0 <3.0.0" From 03a8d2c938da609ae5960f2a2ef5707aa6eba8e3 Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Wed, 11 May 2022 17:40:09 -0700 Subject: [PATCH 2/3] Fix CHANGELOG style, add TODO link. --- packages/ios_platform_images/CHANGELOG.md | 3 +-- packages/ios_platform_images/lib/ios_platform_images.dart | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ios_platform_images/CHANGELOG.md b/packages/ios_platform_images/CHANGELOG.md index 7f2e78569134..d432bdb7ee8e 100644 --- a/packages/ios_platform_images/CHANGELOG.md +++ b/packages/ios_platform_images/CHANGELOG.md @@ -1,7 +1,6 @@ ## 0.2.0+7 -* Ignore deprecation of `load` method in [ImageProvider] so it can be - deprecated at the framework level, without breaking CI. +* Ignores the warning for the upcoming deprecation of `ImageProvider.load`. ## 0.2.0+6 diff --git a/packages/ios_platform_images/lib/ios_platform_images.dart b/packages/ios_platform_images/lib/ios_platform_images.dart index fc08d77ea8f1..21bb740ccae0 100644 --- a/packages/ios_platform_images/lib/ios_platform_images.dart +++ b/packages/ios_platform_images/lib/ios_platform_images.dart @@ -63,6 +63,7 @@ class _FutureMemoryImage extends ImageProvider<_FutureMemoryImage> { } /// See [ImageProvider.load]. + // TODO(jmagman) Implement the new API once it lands, https://github.com/flutter/flutter/issues/103556 @override // ignore:deprecated_member_use ImageStreamCompleter load(_FutureMemoryImage key, DecoderCallback decode) { From 4f97f3b11cb0d5f7325af66a8bd2abd6f7c2db46 Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Wed, 11 May 2022 17:43:27 -0700 Subject: [PATCH 3/3] Use the correct TODO format --- packages/ios_platform_images/lib/ios_platform_images.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ios_platform_images/lib/ios_platform_images.dart b/packages/ios_platform_images/lib/ios_platform_images.dart index 21bb740ccae0..6a85ea0d189b 100644 --- a/packages/ios_platform_images/lib/ios_platform_images.dart +++ b/packages/ios_platform_images/lib/ios_platform_images.dart @@ -63,7 +63,7 @@ class _FutureMemoryImage extends ImageProvider<_FutureMemoryImage> { } /// See [ImageProvider.load]. - // TODO(jmagman) Implement the new API once it lands, https://github.com/flutter/flutter/issues/103556 + // TODO(jmagman): Implement the new API once it lands, https://github.com/flutter/flutter/issues/103556 @override // ignore:deprecated_member_use ImageStreamCompleter load(_FutureMemoryImage key, DecoderCallback decode) {