[url_launcher] Update README to use code excerpts. #6042

New-dev0 · 2022-06-26T14:11:07Z

Updated README.md to use excerpts from the example/lib directory. Ensured all analysis rules pass (like not using deprecated RaisedButton, and other style updates).
Remove url_launcher from script/configs/temp_exclude_excerpt.yaml so excerpts are validated at CI time.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan · 2022-06-26T17:01:57Z

Thanks for the contribution!

All README code changes need to use the new code-excerpt system to ensure that they are correct (and stay correct going forward). Please see the linked docs for an explanation of how to convert the code snippet to the new system as part of this change.

I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.

I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.

These steps are also required, as explained in the docs they link to.

stuartmorgan · 2022-06-30T20:26:26Z

/cc @ditman

stuartmorgan

(Updating review state per comments above.)

ditman · 2022-07-08T20:32:30Z

  url_launcher/url_launcher - ran

There's one instance of documentation that wasn't "extracted" (for iOS), because I couldn't find it anywhere in the example app.

plugins/packages/url_launcher/url_launcher/README.md

Lines 49 to 56 in bde0d0d

    
           Example: 
        
           ```xml 
        
           <key>LSApplicationQueriesSchemes</key> 
        
           <array> 
        
             <string>sms</string> 
        
             <string>tel</string> 
        
           </array> 
        
           ```

flutter-dashboard · 2022-07-08T20:39:42Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

ditman · 2022-07-08T20:41:21Z

I'd argue that tests for this change are running in the readme_excerpts CI step, which this PR enables for the url_launcher/url_launcher package.

stuartmorgan

Thanks for doing this conversion!

stuartmorgan · 2022-07-11T16:40:30Z

packages/url_launcher/url_launcher/example/pubspec.yaml

@@ -9,6 +9,7 @@ environment:
 dependencies:
  flutter:
    sdk: flutter
+  path: ^1.8.2


I think stable is on 1.8.0 or 1.8.1, which is probably why pub get is failing (which on CI is a timeout) in stable analysis.

Indeed:

Because every version of integration_test from sdk depends on path 1.8.1 and url_launcher_example depends on path ^1.8.2, integration_test from sdk is forbidden. So, because url_launcher_example depends on integration_test from sdk, version solving failed. Running "flutter pub get" in example... pub get failed (1; So, because url_launcher_example depends on integration_test from sdk, version solving failed.)

stuartmorgan · 2022-07-11T16:43:17Z

packages/url_launcher/url_launcher/README.md

  <intent>
    <action android:name="android.intent.action.VIEW" />
-    <data android:scheme="sms" />
+    <data android:scheme="https" />


We should excerpt the https block out (by making it a non-contiguous region); https is in the example because it's thing we can use in integration tests on any device that should return true, but there's basically no reason any actual app should need to check for it (for the same reason). I actually recently removed this from the README example.

Done, I've removed the https block from the docregion, and used an empty "plaster" so it doesn't even shows up as "..." in the docs.

stuartmorgan · 2022-07-11T16:47:56Z

packages/url_launcher/url_launcher/README.md

+```dart
+final Uri smsLaunchUri = Uri(
+  scheme: 'sms',
+  path: '0118 999 881 999 119 7253',


🤣

I was about to ask why this wasn't using some obviously fake number (like 123456789) when I realized what it was 🙂

I tried to find a cool "555" number, but ended up going for the easy to remember 0118 999 881 999 119 725... 3

(Turns out I'm almost 7 years late, yikes!)

stuartmorgan · 2022-07-11T16:50:39Z

packages/url_launcher/url_launcher/README.md

-  if (!await launchUrl(uri)) {
-    throw 'Could not launch $uri';
-  }
+if (!File(uri.toFilePath()).existsSync() || !await canLaunchUrl(uri)) {


We've moved pretty strongly away from recommending canLaunchUrl before launchUrl since it most cases—as here—it's actually useless. I'm fine with this new structure, but the second condition should be removed.

Removed the call to canLaunchUrl, and the note about not having a registered handler.

stuartmorgan · 2022-07-11T16:51:31Z

packages/url_launcher/url_launcher/example/android/app/src/main/AndroidManifest.xml

@@ -7,21 +7,25 @@
  -->
  <uses-permission android:name="android.permission.INTERNET"/>

+  <!--#docregion android-queries-->
  <!-- Provide required visibility configuration for API level 30 and above -->
  <queries>
    <intent>


It's probably worth adding a comment saying this is only here for integration tests, and shouldn't be needed in most actual apps, so it doesn't confuse anyone else in the future.

Agreed; I've added a comment to the https scheme bit of the XML, in addition to excluding it from the relevant docregion.

stuartmorgan

LGTM once legacy analysis is happy. Probably you just need to pull the minimum path back a bit further, but if there's an actual incompatibility that you can't resolve you can roll the min Flutter version forward.

ditman · 2022-07-12T19:46:55Z

Probably you just need to pull the minimum path back a bit further

Agh, you're right. I tested with stable but didn't think to go further back in time. I'll get that fixed. Thanks!!

ditman · 2022-07-13T00:35:03Z

2.8.1 corresponds to hash: 77d935a. Digging.

$ flutter --version
Flutter 2.8.1 • channel unknown • unknown source
Framework • revision 77d935af4d (7 months ago) • 2021-12-16 08:37:33 -0800
Engine • revision 890a5fca2e
Tools • Dart 2.15.1

Pub get:

Because every version of integration_test from sdk depends on path 1.8.0 and url_launcher_example depends on path ^1.8.1, integration_test from sdk is forbidden.
So, because url_launcher_example depends on integration_test from sdk, version solving failed.
pub get failed (1; So, because url_launcher_example depends on integration_test from sdk, version solving failed.)

^1.8.0 it is

ditman

Let's land this!

…/plugins#6042)

* Roll Flutter from e291b58 to e9c0ee1 (1 revision) (flutter#5616) * Roll Flutter from e9c0ee1 to b3838eb (1 revision) (flutter#5617) * Roll Flutter from b3838eb to b5321d1 (1 revision) (flutter#5618) * [camera] Update mocktail to latest. (flutter#5614) * Roll Flutter from b5321d1 to 82b91b0 (8 revisions) (flutter#5626) * Roll Flutter from 82b91b0 to 3c9f417 (2 revisions) (flutter#5629) * Roll Flutter from 3c9f417 to 2e1c146 (4 revisions) (flutter#5630) * Roll Flutter from 2e1c146 to 122ab83 (1 revision) (flutter#5631) * Roll Flutter from 122ab83 to 051f1b0 (1 revision) (flutter#5632) * Roll Flutter from 051f1b0 to 35513c2 (1 revision) (flutter#5633) * Roll Flutter from 35513c2 to f7db489 (1 revision) (flutter#5634) * Roll Flutter from f7db489 to 0ea21bc (12 revisions) (flutter#5637) * Roll Flutter from 0ea21bc to f771c9f (1 revision) (flutter#5638) * [github workflow] Resolve token-permissions security alerts (flutter#5627) * Roll Flutter from f771c9f to 0a26277 (3 revisions) (flutter#5641) * Roll Flutter from 0a26277 to 603eb82 (1 revision) (flutter#5644) * Roll Flutter from 603eb82 to 758ebda (6 revisions) (flutter#5646) * Roll Flutter from 758ebda to 2f3f053 (5 revisions) (flutter#5648) * 543cc60 Roll Engine from 387a9b9e300f to b1b0a5adffe9 (1 revision) (flutter/flutter#103159) * 55881f7 Reland "Fix crash from alt-tab'ing just after startup" (flutter/flutter#103093) * 82afe3e Clear the cached data of `RenderBox` if its parent re-layout (flutter/flutter#101493) * b20e27e Does not replace the root layer unnecessarily (flutter/flutter#101748) * 2f3f053 Roll Engine from b1b0a5adffe9 to 47c8a6acf9f3 (1 revision) (flutter/flutter#103164) * Add issues/PRs badges to README (flutter#5649) * Roll Flutter from 2f3f053 to ac30842 (13 revisions) (flutter#5650) * Roll Flutter from ac30842 to e571835 (4 revisions) (flutter#5652) * [local_auth] Overhaul README, and fix `error_codes.dart` visibility (flutter#5653) * Roll Flutter from e571835 to 47f48e4 (5 revisions) (flutter#5654) * Roll Flutter from 47f48e4 to 8e532db (1 revision) (flutter#5655) * Roll Flutter from 8e532db to cc9ac07 (1 revision) (flutter#5656) * Roll Flutter from cc9ac07 to f56c0b3 (1 revision) (flutter#5657) * Roll Flutter from f56c0b3 to d01b0f5 (1 revision) (flutter#5658) * Roll Flutter from d01b0f5 to b05b44e (3 revisions) (flutter#5660) * Roll Flutter from b05b44e to 90868d3 (3 revisions) (flutter#5662) * Roll Flutter from 90868d3 to ae7fcc7 (2 revisions) (flutter#5663) * Roll Flutter from ae7fcc7 to c180971 (1 revision) (flutter#5664) * Roll Flutter from c180971 to c6ced84 (2 revisions) (flutter#5665) * Roll Flutter from c6ced84 to 4bed767 (1 revision) (flutter#5666) * Enable lints `library_private_types_in_public_api`, `sort_child_properties_last` and `use_key_in_widget_constructors` (flutter#5428) * Revert "Enable lints `library_private_types_in_public_api`, `sort_child_properties_last` and `use_key_in_widget_constructors`" (flutter#5691) This reverts commit 4b7b679. This includes a fix for a latent bug in the version-check repo tooling command that caused it to fail when reverting a package that previously had a NEXT section, so that tests will pass. * Re-land: Enable lints `library_private_types_in_public_api`, `sort_child_properties_last` and `use_key_in_widget_constructors` (flutter#5692) Re-lands flutter#5428 This is a revert of flutter#5691 (the revert of the above) with the following changes: - Excludes the repo tooling changes that had to be added to the revert, since we want those - Fixes local_auth: - Updates code for the new analysis failure - Fixes the bad version merge that dropped the version change - Reverts a version change in `file_selector_platform_interface`, which didn't otherwise change * [webview_flutter_wkwebview] The rest of the Objective-C HostApi methods (flutter#5604) * Roll Flutter from 4bed767 to df7111a (42 revisions) (flutter#5696) * Re-sync analysis_options.yaml with flutter/flutter (flutter#5695) The analysis options have gotten behind; this re-syncs to the current state of flutter/flutter. For options that are non-trivial to enable, either because they are non-trivial to fix, or touch a very large number of files, they are locally disabled with clear "LOCAL CHANGE" markers so that it's obvious where we are out of sync. For options that are simple to resolve, they are enabled in the PR. Part of flutter/flutter#76229 * [camera] Fix preview pause orientation (flutter#5209) * [google_sign_in] Add forceCodeForRefreshToken parameter (and new SignInInitParameters class) (flutter#5325) * [image_picker] add requestFullMetadata for iOS (optional permissions) - platform interface (flutter#5603) * [google_sign_in] Fix tests to recognize new request attribute. (flutter#5702) * Roll Flutter from df7111a to a9ac7fb (2 revisions) (flutter#5697) * [ios_platform_images] Ignore ImageProvider.load deprecation. (flutter#5701) * [image_picker] Switch unit tests to mock plaform implementation (flutter#5706) `image_picker`'s app-facing tests were never updated during federation to use a mock platform implementation, and instead were still mocking method channels. That makes them fragile to implementation details of the default method channel implementation that is part of another package, and thus subject to breakage when the method channel changes. This converts them to using a mock platform implementation, so it's only testing the layer within this package. Removes some tests that were testing things that only made sense at the method channel layer. Adds argument assertions that there were tests for, but were previously only enforced in the implementations. As these are API constraints, they should be enforced at the API layer, not at each implementation's layer as they currently are. * [google_sign_in] Switch unit tests to mock platform implementation (flutter#5703) * [ios_platform_images] Ignore ImageProvider.load deprecation (flutter#5707) * Roll Flutter from a9ac7fb to 8bec125 (38 revisions) (flutter#5704) * Roll Flutter from 8bec125 to 6bba577 (17 revisions) (flutter#5709) * Roll Flutter from 6bba577 to b3d7a69 (1 revision) (flutter#5710) * Roll Flutter from b3d7a69 to c13bc34 (2 revisions) (flutter#5715) * [ci] Update the legacy analysis versions (flutter#5699) * Roll Flutter from c13bc34 to ac80477 (2 revisions) (flutter#5717) * Roll Flutter from ac80477 to 2b2cda1 (2 revisions) (flutter#5719) * [tools] Fix `publish` flag calculation (flutter#5694) * [camera]handle iOS camera access permission (flutter#5215) * [image_picker] Fix 'messages.g.h' file not found (flutter#5635) * [ci] Manually roll Flutter master (flutter#5765) * Roll Flutter from 036cae3 to bf7a326 (49 revisions) (flutter#5768) * Roll Flutter from bf7a326 to bb9bbc6 (1 revision) (flutter#5769) * Roll Flutter from bb9bbc6 to fd312f1 (1 revision) (flutter#5770) * Roll Flutter from fd312f1 to c248854 (1 revision) (flutter#5771) * [in_app_purchase] fixed a memory leak error (flutter#5358) * [local_auth] Windows support. (flutter#4806) * [google_sign_in_platform_interface] Add availability to mock models (flutter#5669) * Update cirrus secret. (flutter#5774) * Add more Android plugin owners (flutter#5624) * [google_maps_flutter] Fix native unit tests on M1 (flutter#5772) * [video_player]: Bump exoplayer from 2.17.0 to 2.17.1 in /packages/video_player/video_player_android/android (flutter#5579) * [tools] Validate example READMEs (flutter#5775) * [webview_flutter] Initial v4.0 platform interface implementation (flutter#5109) * [camera] Request access permission for audio (flutter#5766) * Roll Flutter from c248854 to 1994027 (1 revision) (flutter#5777) * [ci/tools] Add iOS/macOS analysis to catch deprecated code (flutter#5778) * Add more CODEOWNERS (flutter#5779) * [tools] Add `update-release-info` (flutter#5643) * [local_auth] Adds federated Windows support (flutter#5776) * [google_sign_in] Upgrade to GoogleSignIn 6.2, support arm64 simulators (flutter#5708) * Roll Flutter from 1994027 to a4a8e73 (31 revisions) (flutter#5782) * [ci] Updates iOS deprecation check to iOS 13 (flutter#5786) * [various] Set minimum Flutter versions to 2.8 (flutter#5792) * [google_maps_flutter_web] Remove custom analysis file. (flutter#5791) * [path_provider] Fix integration tests on macOS (flutter#5773) * [video_player] Fix order-dependent tests (flutter#5672) * [google_sign_in] Suppress `deprecation` warnings (flutter#5049) * Roll Flutter from a4a8e73 to 1e1f4bc (65 revisions) (flutter#5795) * Roll Flutter from 1e1f4bc to 1e10cec (6 revisions) (flutter#5799) * Roll Flutter from 1e10cec to 6aaabf6 (1 revision) (flutter#5800) * Roll Flutter from 6aaabf6 to 4654fd0 (2 revisions) (flutter#5802) * Roll Flutter from 4654fd0 to b8b0c80 (1 revision) (flutter#5803) * Roll Flutter from b8b0c80 to de7c23e (1 revision) (flutter#5804) * Roll Flutter from de7c23e to ec20ea8 (1 revision) (flutter#5805) * [google_sign_in, in_app_purchase_android] Add availability to mock models (flutter#5642) * [Camera] Return all possible cameras on iOS (flutter#5636) * [google_maps_flutter] Updates platform interface to new analysis options (flutter#5793) * [google_maps_flutter] Fix prefer_const_literals_to_create_immutables (flutter#5811) * Roll Flutter from ec20ea8 to 7ece8f9 (3 revisions) (flutter#5813) * Roll Flutter from 7ece8f9 to f852092 (5 revisions) (flutter#5815) * Roll Flutter from f852092 to 9398c14 (3 revisions) (flutter#5817) * Roll Flutter from 9398c14 to 35c0a3e (9 revisions) (flutter#5821) * [ci] Initial migration to Cirrus Apple silicon (flutter#5794) * Roll Flutter from 35c0a3e to 7ca4984 (3 revisions) (flutter#5823) * Roll Flutter from 7ca4984 to e4c7f6e (4 revisions) (flutter#5824) * Roll Flutter from e4c7f6e to ac29c11 (1 revision) (flutter#5826) * Fix issue where map updates don't take effect in Flutter v3.0.0 (flutter#5787) * Roll Flutter from ac29c11 to efb9368 (3 revisions) (flutter#5827) * [ios_platform_images] ignore DecoderCallback deprecation (flutter#5806) * Roll Flutter from efb9368 to b5adbee (10 revisions) (flutter#5830) * [camera] Move camera streaming to platform interface (flutter#5783) * Roll Flutter from b5adbee to da24f10 (10 revisions) (flutter#5832) * [webview_flutter_wkwebview] Update variable names for changes coming in flutter#5700 (flutter#5829) * Roll Flutter from da24f10 to e899573 (15 revisions) (flutter#5834) * [camera] Switch to platform-interface-provided streaming (flutter#5833) * [webview]: Bump gradle from 3.3.0 to 7.2.1 in /packages/webview_flutter/webview_flutter_android/android (flutter#5842) * [webview_flutter_wkwebview] Raise minimum Dart and Flutter version to 2.17 and 3.0.0, respectively. (flutter#5850) * [path_provider] Support unicode encoded version info values (flutter#4986) * [camera_web] Use CameraAccessDenied for permission error (flutter#5784) * [path_provider_windows] Update to ffi 2.0.0 (flutter#5853) * Use Win32 type aliases * Generated file update * Bump version * Bump pub dependency in path_provider_linux * Add integration_test dev dependency * Revert "Add integration_test dev dependency" This reverts commit 40e7778. * Address review comments * [video_player] Android: video_player_android parts of rotationCorrection fix (flutter#5158) * [google_maps_flutter] Objective-C code clean up (flutter#5780) * All the workflows have been migrated to use main. (flutter#5874) Master branch is getting archived. Bug: flutter/flutter#90476 * update key (flutter#5882) * [image_picker_android] Remove `jetifier` and `enableUnitTestBinaryResources` from gradle properties (flutter#5889) * [webview_flutter_wkwebview] Implement one callback method for review of the design (flutter#5700) * ignore upcoming warnings in webview_flutter_platform_interface (flutter#5855) * ignore upcoming warnings in webview_flutter_wkwebview (flutter#5856) * Roll Flutter from e899573 to 889a15e (176 revisions) (flutter#5905) * [image_picker_android] Add jetifier back with gradle and androidx upgrades (flutter#5890) * Update filter to run tasks only on PRs and main branch. (flutter#5883) * Revert "All the workflows have been migrated to use main. (flutter#5874)" (flutter#5907) * Roll Flutter from 889a15e to 2e1ebd8 (6 revisions) (flutter#5910) * Roll Flutter from 2e1ebd8 to 52c47e9 (9 revisions) (flutter#5911) * Add automatic updating of github-actions (flutter#5880) * Revert "Add automatic updating of github-actions (flutter#5880)" (flutter#5917) This reverts commit f781b03. * [video_player] Android: Rotate videos recorded in landscapeRight (flutter#3820) * Re-add tag filter (flutter#5918) Re-adding filter removed in flutter#5883 per [discussion](https://github.com/flutter/plugins/pull/5883/files#r887442326) * [various] Clean up obsolete references to "master" (flutter#5912) * Roll Flutter from 52c47e9 to 1b2ee41 (8 revisions) (flutter#5916) * Add versions to all the dependencies so they are pinned (flutter#5887) * Pinning dependency versions * Update gradle version. * Revert "Update gradle version." This reverts commit 7bf787f. * [ci] Re-disable mirroring to master (flutter#5920) * Ignore upcoming warnings webview_flutter_android (flutter#5922) * ignore upcoming warnings in webview_flutter_android * update-release-info * [github_actions] Add automatic updating of github-actions (flutter#5919) * Revert "Revert "Add automatic updating of github-actions (flutter#5880)" (flutter#5917)" This reverts commit 8ded25d. * Update dependabot.yml Shortened prefix from "github_actions" to "gh_actions" in order to meet the 15 character max length requirement * Roll Flutter from 1b2ee41 to be0c1bd (23 revisions) (flutter#5929) * [url_launcher] Update README discussion of permissions (flutter#5424) * [webview_flutter_wkwebview] Change callbacks setters to anonymous functions (flutter#5921) * Ignore upcoming warnings (flutter#5931) * ignore upcoming warnings * update-release-info * [gh_actions]: Bump lewagon/wait-on-check-action from 5e937358caba2c7876a2ee06e4a48d0664fe4967 to 1.1.1 (flutter#5926) * [gh_actions]: Bump actions/upload-artifact from 3.0.0 to 3.1.0 (flutter#5925) * [gh_actions]: Bump actions/labeler from 3.0.0 to 4 (flutter#5927) * [gh_actions]: Bump actions/checkout from 2.3.4 to 3.0.2 (flutter#5923) * [gh_actions]: Bump ossf/scorecard-action from 1.0.4 to 1.1.1 (flutter#5928) * [webview_flutter_wkwebview] Implement Dart side of Flutter Apis (flutter#5933) * [webview_flutter_wkwebview] Implement Objc side of Flutter Apis (flutter#5934) * [webview]: Bump mockito-inline from 3.11.1 to 4.6.1 in /packages/webview_flutter/webview_flutter_android/android (flutter#5893) * Roll Flutter from be0c1bd to 4ec2965 (24 revisions) (flutter#5935) * [tools] Check integration tests for `test` (flutter#5936) * [gh_actions]: Bump github/codeql-action from 1.1.4 to 2.1.12 (flutter#5924) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.1.4 to 2.1.12. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f5d8227...27ea8f8) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Ignore upcoming warnings (flutter#5939) * [camera] Federate mobile implementations (flutter#5937) * Roll Flutter from 4ec2965 to 25e0e29 (27 revisions) (flutter#5941) * [camera] Publish federated implementations (flutter#5942) * [file_selector]Improve API docs and examples (flutter#4824) * Roll Flutter from 25e0e29 to bc08d85 (36 revisions) (flutter#5951) * Roll Flutter from bc08d85 to 689b5cc (5 revisions) (flutter#5954) * Roll Flutter from 689b5cc to 712860d (4 revisions) (flutter#5956) * [camera] Switch to internal method channels (flutter#5943) * [path_provider] Migrated path_provider_ios to pigeon. (flutter#5944) * Migrated path_provider_ios to pigeon. * increased flutter version to 3.0.0 * [google_maps_flutter] Add structure options to platform interface (flutter#5960) * [ci] Skip expensive native tests on stable in presubmit (flutter#5962) * Ignore deprecation for `styleFrom` button APIs (flutter#5945) * Roll Flutter from 712860d to 0cd8f3d (6 revisions) (flutter#5967) * [google_maps_flutter] Switch to using new structured options interface methods (flutter#5825) * [url_launcher] Fixes call to setState after dispose. (flutter#5963) * [google_maps_flutter] Switch web to structured options (flutter#5965) * [webview_flutter_wkwebview] Fix bug of overriding default values of `NSURLRequest` (flutter#5969) * [webview_flutter_wkwebview] Fixes bug where an `NSError` not an `NSErrorData` was returned (flutter#5973) * [webview_flutter_wkwebview] Implements `currentUrl` (flutter#5974) * [webview_flutter_wkwebview] Return an NSNumber that represents a bool (flutter#5968) * [webview_flutter_wkwebview] Instantiate a `WKWebViewConfiguration` in `WKUIDelegate.onCreateWebView` (flutter#5971) * Reduce dependabot freq from daily to weekly. (flutter#5972) * [webview_flutter_wkwebview] Adds the dispose method to NSObjectFlutterApi (flutter#5970) * [image_picker] Switch Android to internal method channel (flutter#5958) * [webview_flutter_wkwebview] Prevents `NSObject.removeObserver` from being called without calling `addObserver` first (flutter#5975) * [camera] Ignore body_might_complete_normally_catch_error violation (flutter#5957) * Roll Flutter from 0cd8f3d to 873d343 (11 revisions) (flutter#5982) * [path_provider]: Migrated path_provider for android to pigeon. (flutter#5959) * Roll Flutter from 873d343 to 7bad4eb (13 revisions) (flutter#5984) * [video_player] Fix disposed VideoPlayerController throwing an error when calling dispose() again (flutter#5952) * [url_launcher] Add a new launchUrl to platform interface (flutter#5966) This creates a new platform interface method for launching that closely parallels the new public-facing API, so that implementations can switch to implementing a more platform-neutral implementation. This will pave the way for things like cleanly implementing `externalNonBrowserApplication` support on non-iOS platforms. A follow-up will switch the app-facing package to call this new methods instead of the legacy method. Implementation packages can adopt the new method as is useful for them; eventually we can do a cleanup pass if we want to fully deprecate the old method. * Roll Flutter from 7bad4eb to 02558d6 (26 revisions) (flutter#5988) * d88212c added microbenchmark for loading assets (flutter/flutter#105982) * d3bc2bb [framework] fix RangeSlider regression due to touch slop changes (flutter/flutter#106094) * ede7fc6 Add more CMake unit tests (flutter/flutter#106076) * 995b332 Revert "Make RenderSliverGrid more accurately report overflow" (flutter/flutter#106123) * 9e67070 [Conductor] Update post submit location (flutter/flutter#106120) * f67d9b7 Revert "[Conductor] Update post submit location (#106120)" (flutter/flutter#106127) * a783e42 Fix SliverPadding geometry (flutter/flutter#106071) * 3f401a1 Ignore uses of soon-to-be deprecated `NullThrownError`. (flutter/flutter#105693) * 8e8a1c8 Fix `StretchingOverscrollIndicator` clipping and add `clipBehavior` parameter (flutter/flutter#105303) * 96813e9 [gen_keycodes] Clarify the README that the code scheme also applies to physical keys (flutter/flutter#106078) * ddeb0b9 [gen_keycodes] Remove invalid Web code maps (flutter/flutter#106074) * 32b22b8 parse build version on xcodeproj (flutter/flutter#105908) * f104be7 Ignore body_might_complete_normally_catch_error violations (flutter/flutter#105795) * 2c15e3c [flutter_tools] update test/src to null safety (flutter/flutter#106064) * b1b1ee9 [web] Fix JS crash when FF blocks service workers. (flutter/flutter#106072) * fae31ee [flutter_tools] temporary directory (flutter/flutter#105815) * f6f0d60 Update the platform properties for android bots (flutter/flutter#106146) * 1572773 Update package:archive and pin test_api (flutter/flutter#106157) * d08a1b0 Roll Flutter Engine from f8c0dc87bc53 to ee71e31c36ce (41 revisions) (flutter/flutter#106162) * 58007fc Fix debugPaintSize throws 'Null Check error' (flutter/flutter#106108) * c462cfa Roll Flutter Engine from ee71e31c36ce to 3c4ca2762e20 (2 revisions) (flutter/flutter#106167) * cb2569f Roll Flutter Engine from 3c4ca2762e20 to df5144dd451d (1 revision) (flutter/flutter#106171) * 526c33f Roll Flutter Engine from df5144dd451d to 746b33282f74 (1 revision) (flutter/flutter#106175) * b29c64b Roll Flutter Engine from 746b33282f74 to 6cb83ab0f155 (1 revision) (flutter/flutter#106178) * 12f2a35 Roll Plugins from 8bee94c to c3955d2 (3 revisions) (flutter/flutter#106200) * 02558d6 Revert "Fix `StretchingOverscrollIndicator` clipping and add `clipBehavior` parameter" (flutter/flutter#106207) * Added ignore deprecation comments to `styleFrom` button APIs (cont) (flutter#5983) * [webview]: Bump gradle from 3.3.0 to 7.1.2 in /packages/webview_flutter/webview_flutter_android/example/android (flutter#5844) * [webview_flutter] Fixes bug when onNavigationRequestCallback returns false (flutter#5981) * [camera] Fix exception in registerWith (flutter#6009) Fixes a regression from an unintented change in behavior during the conversion to an in-app method channel for Android and iOS. Although the Dart code for their implementations is almost identical to the shared method channel version, the differences in initialization paths caused the platform versions to try to use the widget bindings before they had been set up: The constructor for a `dartPluginClass` is called during `registerWith`, which is before `main`, but the constructor for the default implementation isn't called until `CameraPlatform.instance` is called, since Dart automatically does lazy static class initializtion. To avoid the issue without forcing bindings to be initialized early, this makes setting up the platform channel listener lazily. Fixes flutter/flutter#106236 * Roll Flutter from 02558d6 to dfaec11 (29 revisions) (flutter#6011) * [webview]: Bump annotation from 1.0.0 to 1.4.0 in /packages/webview_flutter/webview_flutter_android/android (flutter#5992) * [webview]: Bump annotation Bumps annotation from 1.0.0 to 1.4.0. --- updated-dependencies: - dependency-name: androidx.annotation:annotation dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * version bump Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> * Ignore upcoming warnings (flutter#6007) * [ci] Ensure complete dependabot coverage (flutter#5976) * [url_launcher] Switch to new launchUrl interface (flutter#5985) * Roll Flutter from dfaec11 to 60f30e5 (23 revisions) (flutter#6015) * [webview_flutter_wkwebview] Update copy method for Dart classes and support the `NSObject.observeValue` for subclasses (flutter#5961) * [webview]: Bump junit from 4.12 to 4.13.2 in /packages/webview_flutter/webview_flutter_android/example/android/app (flutter#6030) * Bump junit to 4.13.2 (flutter#5585) * [path_provider]: Bump junit Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.2. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.2) --- updated-dependencies: - dependency-name: junit:junit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump junit versions Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: camsim99 <camillesimon90@gmail.com> Co-authored-by: Stuart Morgan <stuartmorgan@google.com> * [google_sign_in_platform_interface] Add support for `serverClientId` (flutter#5256) This PR is a prerequisite for implementing flutter#5250. It adds support for passing a server client ID to platform implementations when initializing them. * Roll Flutter from 60f30e5 to a30012b (8 revisions) (flutter#6033) * [camera] Partially Address CameraAccessException: CAMERA_ERROR (flutter#5723) * Roll Flutter from a30012b to 6c3a0e4 (6 revisions) (flutter#6037) * [path_provider] Fixed support for querying the root external storage directory (flutter#6036) * Added ability to purchase multiple quantity of one product (flutter#5711) * ignore upcoming warnings (flutter#6044) * [google_maps_flutter] Temporary fix for initial coordinate when the surface is changed (flutter#6054) * Roll Flutter from 6c3a0e4 to baf8686 (51 revisions) (flutter#6055) * Roll Flutter from baf8686 to 3b11ad8 (13 revisions) (flutter#6058) * Roll Flutter from 3b11ad8 to 6c6ae06 (28 revisions) (flutter#6060) * [tools] Allow skipping packages by Dart version (flutter#6038) * Roll Flutter from 6c6ae06 to 1add0d7 (16 revisions) (flutter#6064) * [tools] Allow pre-release versions (flutter#6061) * testing autosubmit (flutter#6062) * Roll Flutter from 1add0d7 to efd006e (15 revisions) (flutter#6065) * Roll Flutter from efd006e to 629f731 (6 revisions) (flutter#6068) * Roll Flutter from 629f731 to 39a38b7 (16 revisions) (flutter#6076) * [webview_flutter] fix: unreliable encoding for web (flutter#5737) * Roll Flutter from 39a38b7 to 587cf5f (5 revisions) (flutter#6078) * [image_picker_ios] fix wrong plugin name (flutter#6072) * [google_sign_in] Implement Dart-based configuration and `serverClientId` (flutter#6034) * [webview_flutter_wkwebview] Prevent leaking when a callback method references an object that references itself (flutter#6056) * Roll Flutter from 587cf5f to 78e3b93 (23 revisions) (flutter#6080) * [google_sign_in] Support Dart-based configuration and `serverClientId` (flutter#5250) * [camera] Ignore body_might_complete_normally_catch_error violation (flutter#6049) * [sign_in]: Bump gradle from 3.3.0 to 7.2.1 in /packages/google_sign_in/google_sign_in_android/android (flutter#5838) * [video_player] Use epislon to compare values in matrix in test (flutter#6088) * [in_app_purchase] Migrate android to Billing to 5.0.0 (flutter#5405) * [espresso]: Bump okhttp from 3.12.1 to 4.10.0 in /packages/espresso/android (flutter#5955) * [video_player]: Bump gradle from 3.5.0 to 7.2.1 in /packages/video_player/video_player_android/android (flutter#5841) * Roll Flutter from 78e3b93 to d59923b (49 revisions) (flutter#6090) * [quick_actions] Android handle quick action without restart (flutter#5048) * [in_app_purchase] Update json_serializable (flutter#6092) * [camera] Update Android Camera Access Permission Error Codes (flutter#5640) * [google_maps_flutter_web ] Update README.md to discuss mouse issue when stacked (flutter#5875) * Roll Flutter from d59923b to d092601 (35 revisions) (flutter#6095) * [webview_flutter_wkwebview] Switches the platform implementation to use the native API Wrapper (flutter#6031) * [lifecycle]: Bump gradle from 3.5.0 to 7.2.1 in /packages/flutter_plugin_android_lifecycle/android (flutter#5846) * [file_selector] Add `allowsAny` to `XTypeGroup` (flutter#6094) * [camera] Bump camera_web and camera_android versions to update permission exception codes (flutter#6081) * [google_maps_flutter] Removes hotfix for test that changes the map size (flutter#6097) * [url_launcher] Update README to use code excerpts. (flutter#6042) * Roll Flutter from d092601 to 803ef6a (13 revisions) (flutter#6100) * [local_auth]: Bump core from 1.3.2 to 1.8.0 in /packages/local_auth/local_auth_android/android (flutter#5885) * Roll Flutter from 803ef6a to 5a5d021 (22 revisions) (flutter#6103) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: Jesse Seales <103135467+sealesj@users.noreply.github.com> Co-authored-by: moko256 <koutaro.mo@gmail.com> Co-authored-by: stuartmorgan <stuartmorgan@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Co-authored-by: Cássio Silva Oliveira <cassioso@gmail.com> Co-authored-by: Jami Couch <fbcouch@gmail.com> Co-authored-by: Piotr Mitkowski <piotr.mitkowski1@gmail.com> Co-authored-by: hellohuanlin <41930132+hellohuanlin@users.noreply.github.com> Co-authored-by: Huey Zhang <hueyzng@gmail.com> Co-authored-by: ChineseDragon <yimao009@qq.com> Co-authored-by: Alexandre Zollinger Chohfi <alzollin@microsoft.com> Co-authored-by: Hwanseok Barth Kang <tttkhs@naver.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maurits van Beusekom <maurits@baseflow.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Martin Georgiu <martin.georgiu@gmail.com> Co-authored-by: Emmanuel Garcia <egarciad@google.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Matej Knopp <matej.knopp@gmail.com> Co-authored-by: Tim Sneath <timsneath@google.com> Co-authored-by: Kyle Finlinson <kyle.finlinson@verygood.ventures> Co-authored-by: Chris Yang <ychris@google.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by: Alexandre Ardhuin <alexandre.ardhuin@gmail.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com> Co-authored-by: 8rine23 <58650422+TowaYamashita@users.noreply.github.com> Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Co-authored-by: Darren Austin <darren@darrenaustin.org> Co-authored-by: Sam Rawlins <sam.rawlins@gmail.com> Co-authored-by: Navaron Bracke <brackenavaron@gmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: camsim99 <camillesimon90@gmail.com> Co-authored-by: Gabriel Terwesten <gabriel@terwesten.net> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: Vladislav Khomenko <vladislav.homenko@gmail.com> Co-authored-by: Flafy <flafyarazi@gmail.com> Co-authored-by: Alex Sandri <me@alexsandri.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Gary Qian <garyq@google.com> Co-authored-by: TabooSun <taboosun1996@gmail.com> Co-authored-by: idkq <76702881+idkq@users.noreply.github.com> Co-authored-by: Devesh Pal <newdev0@outlook.com>

Update README.md

1248e12

New-dev0 requested a review from stuartmorgan as a code owner June 26, 2022 14:11

github-actions bot added the p: url_launcher label Jun 26, 2022

This comment was marked as resolved.

Sign in to view

Add build.excerpt.yaml and deps. Update CHANGELOG.

7226977

stuartmorgan suggested changes Jul 8, 2022

View reviewed changes

ditman added 5 commits July 8, 2022 13:09

Configure excerpter so it can find Android XML files

8d3c9ea

Add docregions

8d4d5d2

Update README with extracted excerpts.

8938f70

Enable excerpt analysis in CI

0773c55

Update plugin registrants

8a5704c

github-actions bot added platform-android platform-linux platform-windows labels Jul 8, 2022

dart format + update excerpts

d8aaa1d

ditman requested a review from stuartmorgan July 8, 2022 20:32

flutter-dashboard bot added the needs tests label Jul 8, 2022

ditman removed the needs tests label Jul 8, 2022

stuartmorgan suggested changes Jul 11, 2022

View reviewed changes

Address PR comments and issues.

2bf3dc6

ditman requested a review from stuartmorgan July 12, 2022 00:27

ditman changed the title ~~[url_launcher] rename RaisedButton to ElevatedButton~~ [url_launcher] Update README to use code excerpts. Jul 12, 2022

stuartmorgan approved these changes Jul 12, 2022

View reviewed changes

Update path dep to ^1.8.0

9212fed

ditman approved these changes Jul 13, 2022

View reviewed changes

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2022

auto-submit bot merged commit 19f566b into flutter:main Jul 13, 2022

engine-flutter-autoroll mentioned this pull request Jul 13, 2022

Roll Plugins from ea14939cebdb to 19f566ba87aa (7 revisions) flutter/flutter#107539

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022

19f566ba8 [url_launcher] Update README to use code excerpts. (flutter…

47636f8

…/plugins#6042)

yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022

[url_launcher] Update README to use code excerpts. (flutter#6042)

dc6e939

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[url_launcher] Update README to use code excerpts. (flutter#6042)

9293a46

This was referenced Oct 5, 2024

[url_launcher] README instructions for SMS are incorrect flutter/flutter#156281

Closed

[url_launcher] Remove incorrect SMS instructions flutter/packages#7807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[url_launcher] Update README to use code excerpts. #6042

[url_launcher] Update README to use code excerpts. #6042

New-dev0 commented Jun 26, 2022 •

edited by ditman

Loading

This comment was marked as resolved.

stuartmorgan commented Jun 26, 2022 •

edited

Loading

stuartmorgan commented Jun 30, 2022

stuartmorgan left a comment

ditman commented Jul 8, 2022

flutter-dashboard bot commented Jul 8, 2022

ditman commented Jul 8, 2022 •

edited

Loading

stuartmorgan left a comment

stuartmorgan Jul 11, 2022

ditman Jul 11, 2022

stuartmorgan Jul 11, 2022

ditman Jul 11, 2022

stuartmorgan Jul 11, 2022

ditman Jul 12, 2022

stuartmorgan Jul 11, 2022

ditman Jul 11, 2022

stuartmorgan Jul 11, 2022

ditman Jul 11, 2022

stuartmorgan left a comment

ditman commented Jul 12, 2022

ditman commented Jul 13, 2022 •

edited

Loading

ditman left a comment

[url_launcher] Update README to use code excerpts. #6042

[url_launcher] Update README to use code excerpts. #6042

Conversation

New-dev0 commented Jun 26, 2022 • edited by ditman Loading

Pre-launch Checklist

This comment was marked as resolved.

stuartmorgan commented Jun 26, 2022 • edited Loading

stuartmorgan commented Jun 30, 2022

stuartmorgan left a comment

Choose a reason for hiding this comment

ditman commented Jul 8, 2022

flutter-dashboard bot commented Jul 8, 2022

ditman commented Jul 8, 2022 • edited Loading

stuartmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

ditman commented Jul 12, 2022

ditman commented Jul 13, 2022 • edited Loading

ditman left a comment

Choose a reason for hiding this comment

New-dev0 commented Jun 26, 2022 •

edited by ditman

Loading

stuartmorgan commented Jun 26, 2022 •

edited

Loading

ditman commented Jul 8, 2022 •

edited

Loading

ditman commented Jul 13, 2022 •

edited

Loading