Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[share_plus] [Request]: Thumbnail support #1221

Open
ChristianEdwardPadilla opened this issue Oct 12, 2022 · 3 comments · May be fixed by #3372
Open

[share_plus] [Request]: Thumbnail support #1221

ChristianEdwardPadilla opened this issue Oct 12, 2022 · 3 comments · May be fixed by #3372
Labels
enhancement New feature or request triage

Comments

@ChristianEdwardPadilla
Copy link
Contributor

Plugin

share_plus

Use case

See image for expectation:

BBMRzLdUu9RE2mQ
Left: Flutter behavior (no thumbnail screenshot) Right: native behavior with thumbnail

This seems to be available on iOS. Not sure on Android or other platforms.

Proposal

See native functionality above including thumbnail preview.

@ChristianEdwardPadilla ChristianEdwardPadilla added enhancement New feature or request triage labels Oct 12, 2022
@ueman
Copy link
Contributor

ueman commented Oct 12, 2022

Related #1099 (comment)

@Coronon
Copy link
Contributor

Coronon commented Oct 29, 2022

I think that this is actually not very hard to implement, as we already laid the groundwork in 8cf35df. The bigger problem here is indeed the uniformity of the plugin.

@miquelbeltran Is there some sort of official timeline or information on the refactoring that you talked about? I was a little inactive lately, as you know.

PS: If you share a normal image, you should already get the image as thumbnail :)

@miquelbeltran
Copy link
Member

Is there some sort of official timeline or information on the refactoring that you talked about? I was a little inactive lately, as you know.

The idea was to refactor share_plus API to only one share method existed, rather than the 5 currently. However, my availability to work on it changed, and I won't be doing it, so this needs to be re-planned by the maintainer team.

@slaci slaci linked a pull request Nov 27, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants