Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android_alarm_manager_plus): Remove references to v1 embedding #2864

Merged
merged 2 commits into from
May 1, 2024

Conversation

johnmccutchan
Copy link
Contributor

@johnmccutchan johnmccutchan commented May 1, 2024

Flutter will be removing the remains of the android v1 embedding code and to make that easier for you here is a CL.

Please make a release ASAP that includes this change.

Flutter will be removing the remains of the android v1 embedding code and make that easier for you here is a CL.

Please make a release ASAP that includes this change.
@johnmccutchan johnmccutchan changed the title Remove references to v1 embedding fix: Remove references to v1 embedding May 1, 2024
@vbuberen
Copy link
Collaborator

vbuberen commented May 1, 2024

Thanks for opening a PR here.

Could you link the PRs or issue mentioning the removal? I know that it should happen somewhere already, considering how much time passed since v2 introduction, but having a reference to the corresponding PR in Flutter would be helpful.
Also, fixing the Java format check would be awesome (but ignore the integration test failure on API 22 as it is really flaky here).

@vbuberen vbuberen changed the title fix: Remove references to v1 embedding fix(android_alarm_manager_plus): Remove references to v1 embedding May 1, 2024
@gmackall
Copy link

gmackall commented May 1, 2024

This is the most up to date issue flutter/flutter#143531, I've left a comment that is tracking the status

@johnmccutchan
Copy link
Contributor Author

Fixed formatting.

@vbuberen
Copy link
Collaborator

vbuberen commented May 1, 2024

Thanks for sharing the link to the issue and fixing the formatting.
I have just checked the repo and seems like it is only android_alarm_manager_plus that has these leftovers.

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will release this update tomorrow.

@vbuberen vbuberen merged commit 0bb6a1f into fluttercommunity:main May 1, 2024
9 of 11 checks passed
This was referenced Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants