Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a copy of R in job-manager for use in jobtap plugin callbacks #5471

Closed
Tracked by #4175
grondo opened this issue Sep 25, 2023 · 3 comments
Closed
Tracked by #4175

Keep a copy of R in job-manager for use in jobtap plugin callbacks #5471

grondo opened this issue Sep 25, 2023 · 3 comments

Comments

@grondo
Copy link
Contributor

grondo commented Sep 25, 2023

As noted in #3851, there are already a couple use cases where having the allocated R available to jobtap plugins would be convenient. In addition to those documented use cases, having R available from the job-manager will also be necessary in order to update the duration of a running job (#4175), since the current expiration will need to be available to create the new expiration necessary for the resource-update event.

This issue proposes that the job-manager keep a copy of R for jobs as they enter the RUN state. This may mean reworking the scheduler protocol to reply to an alloc request with R instead of putting R in the KVS and replying only after the commit. The job-manager could become the entity that puts R in the KVS or this can be done in parallel.

@garlick
Copy link
Member

garlick commented Sep 25, 2023

Have you already begun working on this? I'd be happy to prototype it and propose any RFC updates needed to RFC 27.

@grondo
Copy link
Contributor Author

grondo commented Sep 25, 2023

No, I haven't. Thanks @garlick!

@grondo
Copy link
Contributor Author

grondo commented Nov 7, 2023

This was fixed by #5472

@grondo grondo closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants