Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate finalizers added while enabled revertOndelete attribute on canary #1124

Closed
VinodReddyE opened this issue Mar 4, 2022 · 0 comments · Fixed by #1125
Closed

duplicate finalizers added while enabled revertOndelete attribute on canary #1124

VinodReddyE opened this issue Mar 4, 2022 · 0 comments · Fixed by #1125

Comments

@VinodReddyE
Copy link

Describe the bug

We are using fluxv2 and flagger. we have enabled the attribute revertOnDeleton on canary.
flagger is adding a duplicate finalizers configuration.

- finalizer.flagger.app
- finalizer.flagger.app

due to duplicate config fluxv2 is not able to validate the config and client-side validation dry run is failing.

To Reproduce

Generated by manifestor. DO NOT EDIT

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
name: spring-boot-example-rest-api
spec:

deployment reference

targetRef:
apiVersion: apps/v1
kind: Deployment
name: spring-boot-example-rest-api

the maximum time in seconds for the canary deployment

to make progress before it is rollback (default 600s)

progressDeadlineSeconds: 720

HPA reference (optional)

autoscalerRef:
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
name: spring-boot-example-rest-api-hpa
service:
# service port number
port: 8080
# container port number or name (optional)
targetPort: 8080
# Istio gateways (optional)
gateways:
- platform/ingress-gateway
# Istio virtual service host names (optional)
hosts:
- "*"
match:
- uri:
prefix: "/spring-boot-example-rest-api/"
rewrite:
uri: "/spring-boot-example-rest-api/"

promote the canary without analysing it (default false)

skipAnalysis: false
revertOnDeletion: true
analysis:
interval: 15s
threshold: 10
maxWeight: 100
stepWeight: 100
stepWeightPromotion: 100
match:
- headers:
cookie:
regex: "^([^;]*?; )?(gcprelease=( ?)([^,]?, ?)?spring-boot-example-rest-api@sha256:xxx( ?,?[^,])?)(;[^;])?$"
webhooks:
- name: "events"
type: event
url: xxx
metadata:
image: "xxx"
strategy: manual
- name: "confirm-promotion"
type: confirm-promotion
url: xxx
- name: "rollback"
type: rollback
url: xx

Expected behavior

A clear and concise description of what you expected to happen.

Additional context

  • Flagger version: v0.24.0
  • Kubernetes version: latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant