Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide additional variables to the metrictemplates custom resource #1351

Closed
njohnstone2 opened this issue Jan 25, 2023 · 0 comments · Fixed by #1355
Closed

Ability to provide additional variables to the metrictemplates custom resource #1351

njohnstone2 opened this issue Jan 25, 2023 · 0 comments · Fixed by #1355

Comments

@njohnstone2
Copy link

Describe the feature

When specifying a custom metrics template there are a fixed set of variables (target, service, interval, etc). There are cases where the provided variables do provide enough information to filter metrics appropriately.

Proposed solution

Extend the canaries.flagger.app CRD to support additional metrics variables (optional) as key/value pairs to be exposed in the message template.

example: canary metric snippet (includes the proposed variables block)

spec:
  ...
  analysis:
    ...
    metrics:
    - name: kafka-lag
      variables:
        cluster: my-cluster
        consumer_group: my-consumer-group
      thresholdRange:
        max: 100
      interval: 1m

Any alternatives you've considered?

The alternative would be to update the metrics to ensure the variables available are exposed to apply filtering but this is not always feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants