Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS spec missing AllowOrigins field #603

Closed
sergiofteixeira opened this issue Jun 1, 2020 · 0 comments · Fixed by #604
Closed

CORS spec missing AllowOrigins field #603

sergiofteixeira opened this issue Jun 1, 2020 · 0 comments · Fixed by #604
Labels
kind/bug Something isn't working

Comments

@sergiofteixeira
Copy link

when using flagger crd to create virtualservice with allowOrigins, the crd will skip the line and in the final virtualService there is no allowOrigins line.

    corsPolicy:
      allowOrigins:
      - exact: "https://foo.com"
      allowCredentials: true

tested with this example.

a little bit critical, since istio 1.6 you have to use allowOrigins instead of origin.

@stefanprodan stefanprodan changed the title allowOrigins Bug CORS spec missing AllowOrigins field Jun 1, 2020
@stefanprodan stefanprodan added the kind/bug Something isn't working label Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants