From 9655ed652f503be6deeb6edcf6d13eb0e191b57e Mon Sep 17 00:00:00 2001 From: Imre Nagi Date: Thu, 23 Jul 2020 07:27:27 +0700 Subject: [PATCH 1/3] Add pod priorityClassName to flagger deployment template Signed-off-by: Imre Nagi --- charts/flagger/templates/deployment.yaml | 3 +++ charts/flagger/values.yaml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/charts/flagger/templates/deployment.yaml b/charts/flagger/templates/deployment.yaml index eac5a1c9c..cb6ebd58e 100644 --- a/charts/flagger/templates/deployment.yaml +++ b/charts/flagger/templates/deployment.yaml @@ -48,6 +48,9 @@ spec: secret: secretName: "{{ .Values.istio.kubeconfig.secretName }}" {{- end }} + {{- if .Values.podPriorityClassName }} + priorityClassName: {{ .Values.podPriorityClassName }} + {{- end }} containers: - name: flagger {{- if .Values.securityContext.enabled }} diff --git a/charts/flagger/values.yaml b/charts/flagger/values.yaml index 257b3a5d4..94286043f 100644 --- a/charts/flagger/values.yaml +++ b/charts/flagger/values.yaml @@ -14,6 +14,9 @@ podAnnotations: prometheus.io/port: "8080" appmesh.k8s.aws/sidecarInjectorWebhook: disabled +# priority class name for pod priority configuration +podPriorityClassName: "" + metricsServer: "http://prometheus:9090" # accepted values are kubernetes, istio, linkerd, appmesh, nginx, gloo or supergloo:mesh.namespace (defaults to istio) From 9aa775f409fbe4fcf0744434163485174a534d11 Mon Sep 17 00:00:00 2001 From: Imre Nagi Date: Thu, 23 Jul 2020 07:33:29 +0700 Subject: [PATCH 2/3] Add priorityClassName to loadtester chart Signed-off-by: Imre Nagi --- charts/loadtester/templates/deployment.yaml | 3 +++ charts/loadtester/values.yaml | 2 ++ 2 files changed, 5 insertions(+) diff --git a/charts/loadtester/templates/deployment.yaml b/charts/loadtester/templates/deployment.yaml index 3120bb120..978c7e504 100644 --- a/charts/loadtester/templates/deployment.yaml +++ b/charts/loadtester/templates/deployment.yaml @@ -27,6 +27,9 @@ spec: {{- else if .Values.rbac.create }} serviceAccountName: {{ include "loadtester.fullname" . }} {{- end }} + {{- if .Values.podPriorityClassName }} + priorityClassName: {{ .Values.podPriorityClassName }} + {{- end }} containers: - name: {{ .Chart.Name }} image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" diff --git a/charts/loadtester/values.yaml b/charts/loadtester/values.yaml index af7a7ffe7..100d61511 100644 --- a/charts/loadtester/values.yaml +++ b/charts/loadtester/values.yaml @@ -9,6 +9,8 @@ podAnnotations: prometheus.io/scrape: "true" prometheus.io/port: "8080" +podPriorityClassName: "" + logLevel: info cmd: timeout: 1h From 23e805965e69b2d727637369f3179125bff21cee Mon Sep 17 00:00:00 2001 From: Imre Nagi Date: Thu, 23 Jul 2020 16:37:37 +0700 Subject: [PATCH 3/3] Update readme for podPriorityClassName Signed-off-by: Imre Nagi --- charts/flagger/README.md | 1 + charts/loadtester/README.md | 1 + 2 files changed, 2 insertions(+) diff --git a/charts/flagger/README.md b/charts/flagger/README.md index 3d5dbc8a1..c2476ecae 100644 --- a/charts/flagger/README.md +++ b/charts/flagger/README.md @@ -140,6 +140,7 @@ Parameter | Description | Default `istio.kubeconfig.key` | The name of Kubernetes secret data key that contains the Istio control plane kubeconfig | `kubeconfig` `ingressAnnotationsPrefix` | Annotations prefix for NGINX ingresses | None `ingressClass` | Ingress class used for annotating HTTPProxy objects, e.g. `contour` | None +`podPriorityClassName` | PriorityClass name for pod priority configuration | "" Specify each parameter using the `--set key=value[,key=value]` argument to `helm upgrade`. For example, diff --git a/charts/loadtester/README.md b/charts/loadtester/README.md index 7c619e483..4b482721d 100644 --- a/charts/loadtester/README.md +++ b/charts/loadtester/README.md @@ -67,6 +67,7 @@ Parameter | Description | Default `istio.gateway.enabled` | Create Istio gateway in namespace | `false` `istio.tls.enabled` | Enable TLS in gateway ( TLS secrets should be in namespace ) | `false` `istio.tls.httpsRedirect` | Redirect traffic to TLS port | `false` +`podPriorityClassName` | PriorityClass name for pod priority configuration | "" Specify each parameter using the `--set key=value[,key=value]` argument to `helm upgrade`. For example,