-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Flux warmer should handle HTTP 429 responses #1401
Comments
There is a backoff implementation for 429 errors merged in master #1354 |
I missed that I was only searching open issues. :) This can be closed then. Any ETA on releasing that? |
I have a log sent to me by another user, version 1.8.1, with exactly the same behaviour.
this goes on for hundreds of lines about 10ms apart. |
In 1.8.1 it does back-off, but it won't cancel outstanding requests, of which there may be hundreds, or suppress the log messages. The recent PR does both of those things. |
For the record, I spent quite some time debugging why there is a parsing error I thought it was a problem with Flux, but it turns it comes from the registry client which expects a json error in the body of the http response. |
@2opremio should that parsing error be raised as an issue? |
Maybe, but given how little attention the |
When the warmer is fetching images, sometimes it can get an HTTP 429 - Too Many Requests.
Currently it logs that is can't parse this response, and immediately retries, adding more and more load to an already overwhelmed server.
In my opinion it should stop bombarding that server, and come back to it later.
The text was updated successfully, but these errors were encountered: