Flux reports failure for helm chart and then success

[jpds]

While debugging for #1819, I deleted the helm release and then flux reported failure deploying the chart followed immediately by a success message:

flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.837039819Z caller=operator.go:301 component=operator info="UPGRADING release"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.837086515Z caller=operator.go:305 component=operator info="Custom Resource driven release upgrade"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.843287719Z caller=operator.go:172 component=operator debug="PROCESSING item [\"production-namespace/production-app\"]"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.843328979Z caller=operator.go:229 component=operator debug="Starting to sync cache key production-namespace/production-app"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.8616102Z caller=release.go:139 component=release info="processing release production-app" action=CREATE options="{DryRun:false ReuseName:false}" timeout=300s
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.959282774Z caller=release.go:186 component=release error="Chart release failed: production-app: &status.statusError{Code:2, Message:\"release production-app failed: Deployment in version \\\"v1beta2\\\" cannot be handled as a Deployment: v1beta2.Deployment.Spec: v1beta2.DeploymentSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Affinity: readObjectStart: expect { or n, but found \\\", error found in #10 byte of ...|ffinity\\\":\\\"podAntiAff|..., bigger context ...|se\\\":\\\"production-app\\\"}},\\\"spec\\\":{\\\"affinity\\\":\\\"podAntiAffinity:\\\\n  preferredDuringSchedulingIgnor|...\", Details:[]*any.Any(nil)}"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:17.987413038Z caller=release.go:190 component=release info="Deleting failed release: [production-app]"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:18.119739783Z caller=operator.go:214 component=operator info="Successfully synced 'production-namespace/production-app'"
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: ts=2019-03-13T11:15:18.121657468Z caller=operator.go:169 component=operator debug="Processing next work queue job ..."
flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: I0313 11:15:18.121287       7 event.go:221] Event(v1.ObjectReference{Kind:"HelmRelease", Namespace:"production-namespace", Name:"production-app", UID:"5aea4958-44e1-11e9-a0f1-02dab9d7b196", APIVersion:"flux.weave.works/v1beta1", ResourceVersion:"1444304", FieldPath:""}): type: 'Normal' reason: 'ChartSynced' Chart managed by HelmRelease processed successfully

[squaremo]

flux/flux-helm-operator-7fb864d794-2wrnk[flux-helm-operator]: I0313 11:15:18.121287 7 event.go:221] Event(v1.ObjectReference{Kind:"HelmRelease", Namespace:"production-namespace", Name:"production-app", UID:"5aea4958-44e1-11e9-a0f1-02dab9d7b196", APIVersion:"flux.weave.works/v1beta1", ResourceVersion:"1444304", FieldPath:""}): type: 'Normal' reason: 'ChartSynced' Chart managed by HelmRelease processed successfully

Yeah, this is a garbage log message -- it's just reporting that it saw the event. I'm going to remove those, they are actively misleading.